Hi Raj.

I noticed that the "IM Alert Settings" tab is still displayed in the user edit form for users who do not have the "IM talk" permission. To me, it would make sense that users who do not have permission to IM should have a configuration tab.

Thanks,
Chris

CommentFileSizeAuthor
#1 im-684760-1.patch571 bytescpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new im-684760-1.patch571 bytes

Raj,

The attached patch seems to fix the issue for me.

Thanks again,
Chris

pahariwalla’s picture

pahariwalla commented

Thanks Chris,

I do believe that you know have the dubious distinction of providing the first ever patch for IM. 

for ($i=0; $i<3; $i++) {
  echo "Hip hip Hooray ! ";
}

A little embarrassing coming across that error after making more than one fix to that routine ... 0-/

much obliged,

Raj

cpliakas’s picture

cpliakas commented

Raj, this is nothing compared to what I have found in some of my modules :-). Thanks for applying the fix.

pahariwalla’s picture

pahariwalla commented

aha ! ... so after wondering why the patch wouldn't patch, i realized that it was diffed from an older version and I had already put in some changes re: this issue ... #568702: IM Alert Settings appears on all users' profiles ... that included your fix. Even if your patch didn't make it in, it still was the first, was right on, and it's the thought that counts, so don't stop patchin! heh heh thanks

cpliakas’s picture

cpliakas commented
Status: Needs review » Closed (fixed)

Marking as closed since the issue is already resolved.