Although the RDF mapping datatype for 'comment_count' is specified as xsd:integer, this datatype is not exposed in the RDFa markup, leading to triples like:

<> sioc:num_replies "4"@en .
CommentFileSizeAuthor
#6 rdf_comment-datatype_685034_6.patch993 byteslinclark
#3 685034_rollback.patch7.5 KBscor
#1 rdf_comment-datatype_685034_1.patch3.89 KBlinclark

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new rdf_comment-datatype_685034_1.patch3.89 KB

This patch adds the datatype to the teaser and node view and adds test for teaser view, node view and tracker.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

scor’s picture

scor commented
Title: The number of comments in RDFa should be typed » [needs rollback] The number of comments in RDFa should be typed
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new 685034_rollback.patch7.5 KB

other unrelated changes were committed with this patch http://drupal.org/cvs?commit=328976, namely block.test, dashboard.module, session.test, system.test

please rollback so we also have time to review the patch in #1 :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

I corrected this. This patch is still committed but I backed out the other changes.

scor’s picture

scor commented
Title: [needs rollback] The number of comments in RDFa should be typed » The number of comments in RDFa should be typed
Status: Fixed » Needs work

Since we now test for the new datatype on:

    $tracker_replies = $this->xpath("//tr[@about='$url']//td[contains(@property, 'sioc:num_replies') and contains(@content, '0') and @datatype='xsd:integer']");

let's also add it to

    $tracker_replies = $this->xpath("//tr[@about='$url']//td[contains(@property, 'sioc:num_replies') and contains(@content, '1')]");

for consistency.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new rdf_comment-datatype_685034_6.patch993 bytes
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -RDF

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +RDF

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.