Similar to #671622: Remove duplication between name and fullname but for the Storm org module.

I propose to remove both the prefix and fullname fields.

Any thoughts?

CommentFileSizeAuthor
#3 storm--685140-3.patch4.17 KBjuliangb

Comments

JGonzalez’s picture

I agree with proposal on this issue more than on person.
I never knew what to put in fullname and prefix for Storm Org. fullname of organization? fullname of main contact?

Does anyone use these fields for different purposes?

tchurch’s picture

I agree. I've been helping a customer implement a Storm installation and they keep asking about this.
I would have thought that Prefix would be more useful under Person (i.e. Mr, Mrs, Miss or whatever, controlled through attributes).

juliangb’s picture

Status: Active » Needs review
StatusFileSize
new4.17 KB

A patch for testing.

Does not remove data from db.

I'm undecided over whether to do this with this change immediately or give users a grace period where the data is hidden but present before putting in an update function to remove it.

bigjim’s picture

+1 to drop the fields.

On the grace period question, the question is how do you warn people? Do you make Full Name an option that can e turned off and on in the Organization settings?

juliangb’s picture

Warn people via release notes. The reason that we have done grace periods for things like this in the past (generally ~3months or a couple of releases later) is because some people won't read the release notes (unadvised anyway!)

It isn't a setting, this is meant to be a simplification by removing something that is unnecessary in 99% of cases.

juliangb’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Needs retesting against 2.x.

juliangb’s picture

#3: storm--685140-3.patch queued for re-testing.

juliangb’s picture

Committed to 2.x. Will not be backported to 1.x.

Created #1046930: Clean up prefix and fullname data to handle the data cleanup followup.

juliangb’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.