Closed (won't fix)
Project:
Diff
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Major
Category:
Task
Assigned:
Reporter:
Created:
14 Jan 2010 at 23:47 UTC
Updated:
5 Dec 2016 at 12:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
broonI was just stumbling across this, too. Currently, there is a possibility to distinguish them by the classes of the containing table cells:
diff-deletedlineanddiff-addedline. Thus, it can be used in CSS to style it like < ins > and < del > tags.td.diff-deletedline span.diffchange { text-decoration: line-through; }Alternatively, with some jQuery it's possible to change the tags:
$('td.diff-deletedline span.diffchange').each(function(index){$(this).after('<del class="diffchange">'+ $(this).html() +'</dev>').remove();});Regards,
sin
Comment #2
mitchell commentedRecent commits to the 7.x-3.x very likely cover this. Therefore marking this as fixed. Please reopen if this isn't in the latest dev branch.
Comment #3
alan d. commentedNote, that the HTML classes should all now be there, but there is no option for DEL / INS option.
Comment #4
mitchell commentedComment #5
alan d. commentedNot sure about 6.x, but you can easily theme this by overriding theme_diff_inline_chunk() in Diff 7.x-3.x and this avoids additional admin settings to select one or the other.
However, changing these elements would probably be the best solution. Best time would be when porting the module to 8.x to avoid upgrade headaches.
Note that this change results in having to fix a lot of CSS, "span.diff-deleted" etc.
Comment #6
alan d. commentedBumping to 8.x, too big of change this late for 7.x
Visual inline already uses this, so the issue is applicable to Split fields / Unified fields.
Comment #7
miro_dietikerOK let's give it a last-minute try. Promoting for decision if 8.x-1.x right now, or later, or no more possible because we again would break things.
Comment #8
drobnjak commentedStarted working on this
Comment #9
drobnjak commentedDiff module is using formatter directly from core. On the screenshot provided, row that is creating improper syntax is highlighted. However, this change would require further changes, as it is displayed in the stack trace, which would require huge amount of time.
Issue for changing syntax is therefore more core related - #2833101: Use DEL / INS tags for Diff comparions changes rather than SPAN.diffchange