Hi,

I am translated this module to hungarian then found a few string cannot translate. I made a patch to amend the admin settings form.

CommentFileSizeAuthor
#1 modr8_admin.inc_.patch2.02 KBdenes.szabo

Comments

denes.szabo’s picture

denes.szabo commented
Status: Needs work » Needs review
StatusFileSize
new modr8_admin.inc_.patch2.02 KB

Sorry, I left the patch.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.1 » 6.x-1.x-dev
Status: Needs review » Fixed 
t('Moderator email address')

typo is fixed.

The others strings are user-entered text, and hence should not be passed through t().

pwolanin’s picture

pwolanin commented

see http://drupal.org/node/606804 re: i18n issues

denes.szabo’s picture

denes.szabo commented

Sorry, but I do not agree with you. These strings are for default values for the email parts. These runs once, first time when you enter into the admin page.

So, when I enter the admin page on my hungarian drupal site, I got there an english text by default. If I change anything there these changes will be stored in the variables. Nothing in connection with the t() or tt().

So, the default values not user entered text, I think.

pwolanin’s picture

pwolanin commented
Status: Fixed » Active

Hm, ok -I see your point - we want the default to be translated.