See title. Earl has changed his mind about it.

My personal oppinion: This was a major wtf.

CommentFileSizeAuthor
#3 views-sync-tab_preview_0.patch1.34 KBdawehner
#1 views-sync-tab_preview.patch3.65 KBmerlinofchaos
views-sync-tab_preview.patch622 bytesdawehner

Comments

merlinofchaos’s picture

merlinofchaos commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new views-sync-tab_preview.patch3.65 KB

I extended this to also work for new displays. As a beneficial side effect, preview no longer gets automatically run when adding a display. Wasn't useful to preview then anyway.

Committed to both branches in 6.x

dawehner’s picture

dawehner
Primary language German
commented

yes yes yes :)
Many saved clicks.

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new views-sync-tab_preview_0.patch1.34 KB

So the patch is nearly ready.

I currently don't know how to solve

*************** Drupal.Views.Ajax.ajaxResponse = functio
*** 79,85 ****
  
      Drupal.attachBehaviors(ajax_area);
    }
-   else {
      // If no display, reset the form.
      Drupal.Views.Ajax.setForm('', Drupal.settings.views.ajax.defaultForm);
      //Enable the save button.
--- 79,85 ----
  
      Drupal.attachBehaviors(ajax_area);
    }
+   else if (!data.tab) {
      // If no display, reset the form.
      Drupal.Views.Ajax.setForm('', Drupal.settings.views.ajax.defaultForm);
      //Enable the save button.
*************** Drupal.Views.Ajax.ajaxResponse = functio
*** 116,121 ****

But it does already works

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

and commited. This is only a problem for the old views js code.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.