Sync Display_id with tabs [#685938]

See title. Earl has changed his mind about it.

My personal oppinion: This was a major wtf.

Comment	File	Size	Author
#3	views-sync-tab_preview_0.patch	1.34 KB	dawehner
#3
#1	views-sync-tab_preview.patch	3.65 KB	merlinofchaos
#1
	views-sync-tab_preview.patch	622 bytes	dawehner

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 12 March 2010 at 01:34

Version:	6.x-3.x-dev	» 7.x-3.x-dev
Status:	Needs review	» Patch (to be ported)

File	Size
views-sync-tab_preview.patch	3.65 KB

I extended this to also work for new displays. As a beneficial side effect, preview no longer gets automatically run when adding a display. Wasn't useful to preview then anyway.

Committed to both branches in 6.x

Comment #2

dawehner

German

CreditAttribution: dawehner commented 12 March 2010 at 07:57

yes yes yes :)
Many saved clicks.

Comment #3

dawehner

German

CreditAttribution: dawehner commented 12 March 2010 at 08:44

Status:

Patch (to be ported)

» Needs review

File	Size
views-sync-tab_preview_0.patch	1.34 KB

So the patch is nearly ready.

I currently don't know how to solve

*************** Drupal.Views.Ajax.ajaxResponse = functio
*** 79,85 ****
  
      Drupal.attachBehaviors(ajax_area);
    }
-   else {
      // If no display, reset the form.
      Drupal.Views.Ajax.setForm('', Drupal.settings.views.ajax.defaultForm);
      //Enable the save button.
--- 79,85 ----
  
      Drupal.attachBehaviors(ajax_area);
    }
+   else if (!data.tab) {
      // If no display, reset the form.
      Drupal.Views.Ajax.setForm('', Drupal.settings.views.ajax.defaultForm);
      //Enable the save button.
*************** Drupal.Views.Ajax.ajaxResponse = functio
*** 116,121 ****

But it does already works