Closed (fixed)
Project:
Invisimail
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Jan 2010 at 02:13 UTC
Updated:
11 Jul 2013 at 23:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
marvil07 commentedwell, it seems like it could be a feature request.
It's kind of duplicate functionality I've seen on gtspam(take a look at its demo)
If maintainers are ok, I could start working on a patch based on that module functionality.
Comment #2
Crell commentedI'd consider such a patch, after the Drupal 7 port is completed.
Comment #3
vinmassaro commentedI just created a quick Drupal 6 patch for this because I needed this functionality. Can someone review and make this better? I think there is probably a way to use one theme function with a condition inside to handle both the unlinked and linked options. Thanks in advance.
Comment #4
Crell commentedWell first off it looks like you've got some tabs in your file. Please fix those first. :-)
Comment #5
vinmassaro commentedSorry about that - new patch attached.
Comment #6
Crell commentedTwo problems with #5:
1) It's a Drupal 6 patch, and this thread is marked for Drupal 7. :-) I'm not accepting new features for D6 at this point, just D7, unless a thread provides both. D7 is the focus.
2) I don't see a reason for the theme function to check if invisimail is enabled. If it's not enabled then the formatter won't exist anyway, including that theme function, so that code couldn't be called in the first place.
Sorry I didn't notice those earlier. My brain saw the tabs and stopped parsing. :-) (Also, remember to set the status to "needs review" if you submit a new patch so people know it needs reviewing.)
Comment #7
vinmassaro commentedI just copied what was there already and modified it to add the mailto, so the business of checking if invisimail is enabled was already part of the D6 module. I think this is a useful feature (I was surprised when I couldn't output an email link using the included formatters?) and if I can get some help cleaning up the patch for D6, I'd be more than happy to get one rolling for the D7 version.
Comment #8
pvhee commentedSeems to be integrated in 7.x now.
Comment #9
marvil07 commentedAs mentioned, this is now a feature added to current 7.x-1.x branch, marking accordingly.