CVS edit link for mbohner

I have written a module for Ubercart 2.x Drupal 6.x providing shipping cost calculation based on supplier, weight or order of the individual product. It is based on uc_tablequote. The supplier feature adds quite some complexity to it, so it is not just an extension of the previous mentioned module. Suppliers are defined as a taxonomy vocabulary and each product needs to specify a term. In "Home » Administer » Store administration » Configuration » Shipping quote settings" one is able to create a table consisting of (supplier, min weight/#order, max weight/#order, shipping rate)-records. Shipping cost is calculated individually per item in shopping cart and added up. Name of the module: uc_supplier_tablequote.
(Test-)Example of table created:
Supplier Minimum value Maximum value Shipping Rate
AngusRobertson 0 0.9 10
AngusRobertson 0.901 2 20
AngusRobertson 2.001 999999 50
Happy Books 0 1 15
Happy Books 1.001 2 30
Happy Books 2.001 999999 100
CommentFileSizeAuthor
#4 uc_supplier_tablequote.zip5.16 KBmbohner
#1 uc_supplier_tablequote.zip4.83 KBmbohner

Comments

mbohner’s picture

mbohner commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new uc_supplier_tablequote.zip4.83 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Module review
tr’s picture

tr commented
Status: Needs review » Needs work

The attached file is not a .zip file. Hard to review when it won't extract ...

mbohner’s picture

mbohner commented
Status: Needs work » Needs review
StatusFileSize
new uc_supplier_tablequote.zip5.16 KB

Right. This one should extract. Thanks.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Closed (won't fix)

I see too much code copied from uc_tablequote.module. In the requirements for applying for a CVS account is stated that the module must not duplicate the work done in existing projects, and in another page (which was first part of the requirements page, while now is a sub-page) it's stated that the module / theme should demonstrate ingenuity and originality by the author.