I have a new user on my site and it seems the tags he choses for his posts are not added to vocabulary. When I as amin user will all available permissions post something using the same tag, it is shown in the "tag cloud". Also the drop-down list you get to see when selecting tags displays the tag, even though the cloud wouldn't display it.

I have all the terms in the freetagging vocabulary shown in a box, I got the code from somewhere... When he choses a new term, it is not displayed in the box; when I choose the same term it is displayed in the box.

So far all my two users have been "admin users", that is their role had all available permissions checked.

Is there a permission I forgot to check? Is this related to something else? What an I do to find out?

Comments

Bèr Kessels’s picture

Category: bug » support

This is strange.
Do you have access to the database. Have you got knowledge of MySQL? Can you run SQL queries by hand? If so, I would like to walk you trough some

Also note that the amount of tags in a cloud are limited to a certain number, 60. the 61st, 62nd etc tag won't show up!

And last: please post a full list of enabled and installed modules here. As well as modules you had once installed but removed now. This, because most of the times a conflict in module cuases such bugs.

housetier’s picture

yes I have access to the database; I know something about MySQL; I can run mysql queries, I am not afraid of doing that :)

I have reached the limit of 60 items. How can I increase this limit?

If you think you still need the module list, I will provide it. However, I think it's the limit thing and not an interfering module.

housetier’s picture

Status: Active » Closed (fixed)

I figured it out myself; I changed

function tagadelic_get_weighted_tags($vids, $steps = 6, $size = 60) {
  if (!is_array($vids) || count($vids) == 0) {
    return array();
  }

to

function tagadelic_get_weighted_tags($vids, $steps = 6, $size = 120) {
  if (!is_array($vids) || count($vids) == 0) {
    return array();
  }
Bèr Kessels’s picture

Title: user's tags are not added to the vocabulary » Introduce amount-per-cloud setting
Assigned: Unassigned » Bèr Kessels
Category: support » task
Status: Closed (fixed) » Needs review

Please test this patch. If people like it, I will commit it.

It add a setting for the amount of tags that will show up on a cloud or page.
Currently hardcoded to 60.

Bèr Kessels’s picture

StatusFileSize
new1.68 KB

^^This patch :)

housetier’s picture

After successfully applying the patch, I see the text

The amount of tags that will show up in a cloud.

on mysite.com/admin/settings/tagadelic. But I do not see an input field or anything where I could change the value.

Bèr Kessels’s picture

StatusFileSize
new1.68 KB

new patch

housetier’s picture

I couldn't apply the second patch after the first, so I redownloaded the module and only applied the second patch (...patch_0.txt).

This time I see the input field, with the default value of 60. But the other settings have vanished now! Is this intended?

Also, I cannot set a value:

An illegal choice has been detected. Please contact the site administrator.

I have uploaded a screenshot to imageshack: http://img223.imageshack.us/img223/8382/11515751519rz.jpg

beginner’s picture

StatusFileSize
new2.1 KB

The error is fixed in this patch.

Also, in tagadelic.css, you have definitions for classes up to level 10 (.tagadelic.level10), but the code was hard-coded to set only 6 levels.
I added another configuration setting to set the number of levels. I left 6 as the default, but maybe 10 would be a better default since values are already coded.

Just curious: why 6 and 60 for those two settings?

beginner’s picture

I forgot: values set are not being validated, but the admin knows better than to put anything but an integer in there...

housetier’s picture

Title: Introduce amount-per-cloud setting » ...patch_1.diff.txt seems has no effect on display of tagcloud

I applied this patch, and could then set values without error messages. However, the tag cloud didn't look different, regardless of the values I set.

When I restored the unpatched module and hardcoded the values, I immediately saw the difference upon page reload.

Bèr Kessels’s picture

«Just curious: why 6 and 60 for those two settings?»
6 because there are also 6 header levels: http://www.w3schools.com/tags/tag_hn.asp 60 because that is 10*6 :-)

beginner’s picture

Title: ...patch_1.diff.txt seems has no effect on display of tagcloud » Introduce amount-per-cloud setting

@Bèr : Oh, ok :) I would never have made the connection with h1-h6. :)

@housetier: It works for me. Try emptying the cache, or edit and save a node.

beginner’s picture

Status: Needs review » Reviewed & tested by the community

this patch in action:
http://www.wechange.org/tagadelic/topics
with ten levels and 120 items.

Bèr Kessels’s picture

Version: 4.7.x-1.x-dev » master
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, Thanks a lot!

housetier’s picture

beginner: thank you for your work.

I trust you and others when you say it works. I cannot get it to work the way I expect. When I increase the number of tags from 30 to 100 I expect to see 100 tags, at least much more than 30. If I decrease this number to 30, I expect to see no more than 30 tags. However, nothing ever changes. I have disabled drupal's cache and I have emptied my browser cache too. There is no caching proxy in between, and I haven't installed a PHP cache yet. Furthermore I created a new node and chose new tags, these tags then did not show up in the tag cloud and the number of tags does not change either: I go from 30 to 100, create the node, and still only see these 30 tags.

I will leave this ticket as "fixed" and just edit the source code by hand. It's only two numbers and I immediately see results, even when drupal's cache is enabled. Maybe I'll see the light when I dig deeper into the module system.

Thank you for tagadelic!

beginner’s picture

You're welcome and, yes, thank you to Bèr too for maintaining tagadelic.

What you describe is puzzling. There must be something else at hand, but I have no clue what it can be.
I used the settings to reduce the nb of tags down to 15, and, even though I use the cache, I saw the results immediately, even for an anonymous user.
For the next 24 hours, you can see 15 tags only, as set in admin > settings > tagadelic:
http://www.wechange.org/tagadelic/topics .

If you ever find out why it doesn't work for you, come back and post the reason/ solution here.

Blessings.

Anonymous’s picture

Status: Fixed » Closed (fixed)