bad ordering of user registration fields when account fieldset is used

Bah, no. :P That's cheesy and it also doesn't work. :P

Actually no. I don't see another way to fix this other than hard-coding the field weights. I threw a print_r($form) on line 186 of logintoboggan.module (at the end of the user_register form ID check).

Here's the output with no extra things on the registration form:

Array(
  ...
    [name] => Array
        (
            [#type] => textfield
            [#title] => Username
...
    [mail] => Array
        (
            [#type] => textfield
            [#title] => E-mail address
... (lots more here.. #validate, #submit, etc.)
    [conf_mail] => Array
        (
            [#type] => textfield
            [#title] => Confirm e-mail address
...
    [pass] => Array
        (
            [#type] => password
            [#title] => Password
...
    [conf_pass] => Array
        (
            [#type] => password
            [#title] => Confirm Password
...

Then here's the output when there's stuff added:

Array
(
...
    [account] => Array
        (
            [#type] => fieldset
            [#title] => Account information
            [name] => Array
                (
                    [#type] => textfield
                    [#title] => Username
...
            [mail] => Array
                (
                    [#type] => textfield
                    [#title] => E-mail address
...
            [pass] => Array
                (
                    [#type] => password
                    [#title] => Password
...
            [conf_mail] => Array
                (
                    [#type] => textfield
                    [#title] => Confirm e-mail address
...
            [conf_pass] => Array
                (
                    [#type] => password
                    [#title] => Confirm Password

I have NO idea why it's doing this! LT has the following code which allows for this test case and is putting the fields in the correct order:

        // Have to put these in the login form group if it's been created
        if (isset($form['account'])) {
          $form['account']['conf_mail'] = $form['conf_mail'];
          $form['account']['pass'] = $form['pass'];
          $form['account']['conf_pass'] = $form['conf_pass'];
          unset($form['conf_mail']);
          unset($form['pass']);
          unset($form['conf_pass']);
        }

(my print_r is right after this block -- there's nothing else that can be interfering)

So unless anyone has any better ideas, I'm going with the weight fix. :P This patch is a bit more robust than my other one, in that it should ensure these fields show up in order, regardless of other modules that may be injecting fields into this form in their own hook_form_alters. It's still kind of a cheesy fix, but I honestly don't know what else to do.

Nearing the point of wanting to scream now. ;) So that patch fixes it on my localhost running PHP 5 but not on my work server running PHP 4. *sigh* Will see what else I can come up with...

OKAY. hehe. Let's try this. Seems to work in both places, and no cheesy weight crap. No idea why the "normal" way won't work, but whatever.

Nooooooooooooooooooooooooooooooooooooo!

Now the ressinfressin validation doesn't pass. :(

Must be another blankety-blanking difference between PHP 5 and PHP 4... PHP 5 correctly inserts $form['account']['mail_conf'], etc. PHP 4 inserts it as $form['account'][0]. SIGH. >:\

Ok, I officially give up. Here's a weight patch I tested and works on both servers. Maybe someone smarter than me can come in and figure out what I'm overlooking later, but for now this works.