hi

good job, this module works in d6.

see attached zip file.

could somebody please commit this module.

CommentFileSizeAuthor
belatedPNG.zip9.88 KBakaserer

Comments

noomz’s picture

Thanks you so much,

noomz

kiwimind’s picture

Great, have got this up and working having struggled with PngFix.
I hope that this module is released officially some time soon.
If you're after a co-maintainer, just ask!
Cheers.

mrjeeves’s picture

would anyone be interested in including this method as a layer of png behave? i have also petitioned the maintainer of pngfix to work on a collaboration of our efforts.

if there is interest still, i will release a branch of pngbehave with this backend AS WELL AS the htc version. presence of values in the admin page will indicate which fixes need to be loaded, or something similar.

kiwimind’s picture

Personally, I would be all for seeing these under one umbrella, but I have consistently found that the Belated png script used for this module to be very stable and easy to use. I haven't found the others to be the case. You need to either add selectors in to make backgrounds work or other similar workarounds. This one just works.

Looking forwards:

Would you have a selector as to which script to use?
If you only wanted to used the belated png fix, does this mean you can ignore the others?
Won't your module get a little bloaty if you have too many ways of doing one thing?

I would like to see this module flourish, whether that's as part of yours or as a stand-alone. If the latter, then I feel there is a case for the 2 modules to live side by side as they use very different methods to accomplish this. I don't see this as duplication.

Love to hear more of your thoughts on this.

Cheers.

mrjeeves’s picture

after working through many issues related to the three main methods of working with png's, i've found pngbehave, and belatedpng handle nearly all use cases, there are parts of belated that do not work for some people, while the same is true for pngbehave. since the two libs are very small in and of themselves, i do not feel that offering both in a single module would cause undue bloat. that said, i do think that a hard "switch" for which method to use would be needed (default would have to be pngbehave to maintain a clean upgrade path). if this sounds good, then i'll release a new branch of the 6.x and 7.x flavors with both libs.

kiwimind’s picture

Good idea about the hard switch mrjeeves. Look forward to seeing it all come together.
Are you suggesting that Pngfix is now becoming redundant if pngbehave and belatedpng cover nearly all use cases?
Presume also that this module will then become redundant, although it does seem to have stalled anyway.
Will head on over to pngbehave now.
Cheers.

mrjeeves’s picture

It is not at all significant to me "where" the code lives, At the time I created pngbehave, I thought that having multiple modules to do the same thing provided selection to the users (as is encouraged in some other communities) I realize now that Drupal is aiming to consolidate, not diversify. Since there is interest shown, I will put a 2.x branch out that includes both libs.

mrjeeves’s picture

PNGBehave now has a switch for library and the backgroundimagecache.

kiwimind’s picture

Ok, thanks for that, I will make sure to take a look and post in the issue queue there if necessary.

mrjeeves’s picture

Status: Patch (to be ported) » Fixed

As PNGBehave now offers this built-in, i'm marking this as fixed.

Status: Fixed » Closed (fixed)
Issue tags: -module, -zip, -belatedpng

Automatically closed -- issue fixed for 2 weeks with no activity.