PHP error after upgrading to version 5.x-2.4 [#687368]

After implementing the upgrade of the update status module, I get the following php error:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /path/to/drupal/sites/all/modules/update_status/update_status.module on line 727

PHP version 5.2.6, Drupal version 5.21

Comment	File	Size	Author
#1	687368-1.call-time-pass-by-ref.patch	1.6 KB	dww

Comments

Comment #1

dww

we/he/they

commented 17 January 2010 at 16:26

Assigned:	Unassigned	» dww
Status:	Active	» Needs review

Status	File	Size
new	687368-1.call-time-pass-by-ref.patch	1.6 KB

Argh! :( I thought we caught all this kind of stuff after weeks of testing 5.x-2.x-dev. Ugh. Sorry about that!

Try this...

Comment #2

Tobi2000 commented 17 January 2010 at 17:57

Ok, the error message is gone with the patch applied.

Comment #3

dww

we/he/they

commented 17 January 2010 at 20:41

Version:	5.x-2.4	» 5.x-2.x-dev
Status:	Needs review	» Fixed

Committed to DRUPAL-5--2. Ugh, wonder if I should ship 5.x-2.5 for this. :( Was it a fatal error for you or just a notice/warning?

Comment #4

Tobi2000 commented 17 January 2010 at 21:04

It was just a notice, but for some reason, I couldn't suppress it even by setting the appropriate error reporting option. So even though it wasn't literally fatal, it was not possible to live with it. If there aren't any other people with the same problem, then that might have been a product of my specific setup.

Comment #5

dww

we/he/they

commented 17 January 2010 at 21:10

there's a php.ini setting that allows this (as explained in the error message itself):

If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file

It's still lame, I don't know how that code slipped in. :( Came from #162788: Include modules that aren't enabled, but I don't know why we didn't see any trouble. Alas...