Posted by moshe weitzman on January 18, 2010 at 1:03am
| Project: | Drush |
| Version: | All-versions-5.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Here is some in progress code to deal with memory exhaustion when running a batch. I really need for #211182: Updates run in unpredictable order to land before I can make much progress. That patch there is going to require changes in our updatedb process. Namely, we have to call update_resolve_dependencies() or call its wrapper, update_batch().
| Attachment | Size |
|---|---|
| updatedb.patch | 6.63 KB |
Comments
#1
here's an updated patch
well. rewritten.
it is for d6 and d7.
apply the drush patch and then drop the batch_X.inc files into commands/core/drupal
#2
Thanks a lot. adrian explained via IM that this patch implements our own batch processing that honors the same batch definitions as expected by core. This turned out to be the sanest way to implement updatedb, for example.
I'll give this a test as soon as core gets its upgrade path sorted. Should be this week.
We need a @file declaration at top of batch.inc files explaining the deficiencies in core batch api and how our batch processing is different.
#3
i committed a cleaned up and documented version of this.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.