First, thanks for a fantastic module. It's a real help in keeping coding standards high so is serving all developers and ultimately all Drupal users.

I recently came across the following. It appears that even on its most "picky" level, Coder does not validate function names the Drupal coding standard (http://drupal.org/coding-standards) which states in section Naming conventions):

Functions should be named using lowercase, and words should be separated with an underscore. Functions should in addition have the grouping/module name as a prefix, to avoid name collisions between modules.

That is: coder does NOT report on
1) function names containing uppercase letters
2) function names that do no have a module name prefix

Is there a good reason for this, or is this a bug?

Comments

rdeboer’s picture

The above made me wonder: are there other known deviations from/exceptions to the Drupal coding standards and are these documented anywhere?

douggreen’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

We should have a rule that looks for uppercase function names (that aren't class methods). I dont think we want to go the extra step and check that all functions are name spaced to the module name, but i could be wrong.

douggreen’s picture

Assigned: Unassigned » douggreen
Status: Active » Closed (fixed)
rdeboer’s picture

Cool!