Hi Sir,
I am Unable to see/ read feedback messages in admin/reports/feedback for bot he 6.x-2x-dev and 6.x-2.0 versions.
Screenshot is attached.

Please help.........

CommentFileSizeAuthor
#6 feedback_php53fixes.patch746 bytesberdir
Screenshot-2.png137.52 KBragavendra_bn

Comments

sun’s picture

Category: bug » support
Priority: Critical » Normal
Status: Active » Closed (won't fix)

Most likely, your site's theme is interfering with the content markup. Try with one of the stock core themes and if that works, debug your theme.

ragavendra_bn’s picture

Thanks sun for the aid at the right time. As you said, it has got to do with the theme itself I to suppose. I got the below error in the log. Not sure, as to how to go about it.

Message Parameter 1 to theme_feedback_admin_view_form() expected to be a reference, value given in /home/fashion/public_html/store/includes/theme.inc on line 617.

Note: I am not having any issues with the same code on my localhost, which has php-5.2.9-2 version.
Recently the PHP on the hosting server was updated to 5.3.1. May be this could be it.

sun’s picture

Title: Unable to see/ read feedback messages in admin/reports/feedback » Comaptibility with PHP 5.3
Category: support » bug
Status: Closed (won't fix) » Active

Thanks, now we can do something about this.

ragavendra_bn’s picture

Yup. You are right Sir............

Only need to remove the & before &$form.

Patched line# 66 on feedback.admin.inc as below

ec_customer.theme.inc line 53
function theme_feedback_admin_view_form(&$form) {
+ function theme_feedback_admin_view_form($form) {

Able to see the messages as of new. Not sure of any more updates that needs to be done.

oriol_e9g’s picture

Issue tags: +PHP 5.3

tagged

berdir’s picture

Status: Active » Needs review
StatusFileSize
new746 bytes

Yep, removing the & is correct. The attached patch does this too.

sun’s picture

Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)
Issue tags: -PHP 5.3

Automatically closed -- issue fixed for 2 weeks with no activity.