Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I ran the module through coder and fixed most of the missing pieces.
There is still a lot more that could be updated, but I wanted to make sure you are agreeable to these kinds of changes before continuing.
| Comment | File | Size | Author |
|---|---|---|---|
| codercleanup_radioactivity.patch | 32.88 KB | greggles |
Comments
Comment #1
skiminki commentedThese are all whitespace and comment changes? I don't have anything against them, but maybe wait until I review and commit some pending patches to the CVS. I'd expect that to happen this weekend – maybe even run coder myself ;)
Comment #2
skiminki commentedRun coder module and fixed about all the issues it revealed in the 'normal'-level review run. My run (commit) doesn't include any formatting changes, except those complained by coder. Also, single potential SQL issue (not a confirmed bug, though) was revealed. See details in line 76 of the diff.
Also, cherry-picked fixes from the description for radioactivity_node.test http://drupal.org/cvs?commit=319022. Anyways, thanks to greggles for enlightening me of existence of coder, even if I didn't use much of the patch provided (I wanted to browse all the issues in hope to freshen up my coding style).
I'm leaving this issue open for a while in case anyone wants to contribute some well-justified formatting changes.
Comment #3
skiminki commented