This patch allows drush_make to fallback to a public url if the private one fails. This is useful for our projects where github.com has both private and public urls, and all of the programmers don't have or need contributor access to every project. This way the project downloads as an export if it can't do so as a checkout. Working, tested simple patch attached.

Thanks,
David

CommentFileSizeAuthor
drush_make-gitfallback.patch2.24 KBDavid Goode

Comments

dmitrig01’s picture

dmitrig01 commented

Please use parse_url instead of whatever magic you're using -- thanks!

David Goode’s picture

David Goode commented

parse_url doesn't work properly on github's urls. This is the only git repos I've used drush make with--if there are other different url or transport formats we should support, input would be appreciated. The public and private versions, respectively, are "git://github.com/developmentseed/mn_world.git" and "git@github.com:developmentseed/mn_world.git". The former parses reasonably, but parse url can't do anything with the latter, just returning the 'path' as the entire thing, so using the built-in php function would still require some str_replacing and add'l logic to get it to a viable format, which probably isn't worthwhile.

dmitrig01’s picture

dmitrig01 commented
Status: Needs review » Fixed

Ok, wfm. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.