While installing this module I noticed that after importing pictures the thumbnails wouldn't show up under the "edit" menu. This is because $file does not exist and should be $f->basename

Also included in the patch is a call to krsort to insert the images in sorted order (very useful for me), and a small grammar/translation nit pick.

I know I probably shouldn't have done two fixes with one patch. sorry.

Let me know if this is helpful or if something else would be more helpful. I'm not that adept at making patches, I used "diff -Naur gallery_assist_upport_original gallery_assist_upport > sort_and_filename.patch"

CommentFileSizeAuthor
#1 sort_and_filename.patch2.64 KBKeithBHarrison

Comments

KeithBHarrison’s picture

KeithBHarrison commented
StatusFileSize
new sort_and_filename.patch2.64 KB
KeithBHarrison’s picture

KeithBHarrison commented

After playing with it a little more I believe the krsort should be a ksort instead

jcmc’s picture

jcmc commented
Category: bug » task
jcmc’s picture

jcmc commented
Status: Active » Needs review

Hello KeithBHarrison,

I need your feedback if you are using GA today. The save mechanism is a little changed to satisfy and respect the weights by saving. Now I have a question to you. It is necessary to implement the ksort and maybe the krsort before saving?

If yes I will implement both variants in the upload configuration.

Thanks in advance
Juan Carlos