Closed (fixed)
Project:
Fancy Login
Version:
6.x-1.2-rc1
Component:
Documentation
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jan 2010 at 13:19 UTC
Updated:
10 Feb 2010 at 23:40 UTC
Hello,
In fancy_login.js on line 96 there is:
$("a[href*='user/login']").each(function()
But if you use an alias for the login path, JS can not find the link unfortunately as it is hard coded, and FL breaks.
Possibly there are many non-English users who path aliased the login path, and they might think the module is broken or has junky coding.
I know it is (almost) impossible to get the alias of a path as a JS variable, but at least this can be documented. A minor glitch, but may be critical.
Tx.
Comments
Comment #1
jaypanI may be able to fix this. I changed the code locally in my development version of the module, and it still works, but I'm not sure how you have it aliased, so I need you to test it out for me and let me know if it works.
There are two pieces of code you have to change. First, open up fancy_login.module, and replace this code:
with this code:
Note: ignore the opening and closing php tags (<?php and ?>). Use all the code between them.
Next, open open up scripts/fancy_login.js, and go to line 96 (the one you mentioned earlier, and replace this code:
$("a[href*='user/login']").each(function()with this code:
$("a[href*='" + Drupal.settings.fancyLogin.loginPath + "']").each(function()Depending on how you have aliased the login path, this *should* work. But we'll only know with testing. If it does work, let me know, and I will commit these changes tot he module and re-release it.
Comment #2
jaypanComment #3
chawl commentedPatch is perfectly working (for me) with an aliased login path, tx :)
Comment #4
jaypanGreat! I'll commit this and re-release the module with the changes.
Edit: Thanks for testing that for me.
Comment #5
chawl commentedKind of you :) Also confirming RC2 is OK, then...
Comment #6
jaypanYes, the changes were committed for RC2.