The caching is not working. I do not fully understand the problem, but if I cache the proxy request, and then try to retrieve it, the data looks right, but setting the headers on the Menu Router does not seem to work.

(i have not done checking to see if it indeed is working fine outside the menu router functionality.)

CommentFileSizeAuthor
#3 proxy.patch1.58 KBjapanitrat

Comments

japanitrat’s picture

japanitrat commented

It seems there are missing files in the current HEAD revision. I can't spot proxy.inc

zzolo’s picture

zzolo commented

Updated. I forgot to add the includes directory.

japanitrat’s picture

japanitrat commented
Status: Active » Needs review
StatusFileSize
new proxy.patch1.58 KB

I don't know why it's not handled by cache_get (actually I wasn't developing with cache so much up to this point), but it seems that the expire value is never checked against current time. I added a check in _proxy() and it seems to work with that.

Also there is no need to manually (un-)serialize the cached data since this is handled by cache_get

japanitrat’s picture

japanitrat commented

wondered and searched. So here is further information on this topic:

http://drupal.org/node/534092
http://civicactions.com/blog/2009/jul/28/drupal_gotchya_cache_get_return...

zzolo’s picture

zzolo commented
Status: Needs review » Fixed

@japanitrat

Great work! Thank you! Seems pretty much like a bug with the get_cache(), but its hard to say.
http://drupal.org/project/cvs/689342

japanitrat’s picture

japanitrat commented

np, you're welcome

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.