Download & Extend

Caching is not working with Menu Router

Project:Proxy
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:zzolo
Status:closed (fixed)

Issue Summary

The caching is not working. I do not fully understand the problem, but if I cache the proxy request, and then try to retrieve it, the data looks right, but setting the headers on the Menu Router does not seem to work.

(i have not done checking to see if it indeed is working fine outside the menu router functionality.)

Comments

#1

It seems there are missing files in the current HEAD revision. I can't spot proxy.inc

#2

Updated. I forgot to add the includes directory.

#3

Status:active» needs review

I don't know why it's not handled by cache_get (actually I wasn't developing with cache so much up to this point), but it seems that the expire value is never checked against current time. I added a check in _proxy() and it seems to work with that.

Also there is no need to manually (un-)serialize the cached data since this is handled by cache_get

AttachmentSizeStatusTest resultOperations
proxy.patch1.58 KBIgnored: Check issue status.NoneNone

#4

wondered and searched. So here is further information on this topic:

http://drupal.org/node/534092
http://civicactions.com/blog/2009/jul/28/drupal_gotchya_cache_get_return...

#5

Status:needs review» fixed

@japanitrat

Great work! Thank you! Seems pretty much like a bug with the get_cache(), but its hard to say.
http://drupal.org/project/cvs/689342

#6

np, you're welcome

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here