minimal module enabled. this should be minimal profile enabled if at all anything.

CommentFileSizeAuthor
#16 install-profile-is-referred-to-module-during-installation-689396-16.patch2.09 KBrjgoldsborough
#8 d8_install_profile.patch2.08 KBrjgoldsborough
#6 d7_profile_installed_notification.patch647 bytesrjgoldsborough
#4 d7_profile_installed_notification.patch664 bytesrjgoldsborough

Comments

David_Rothstein’s picture

David_Rothstein commented
Title: first watchdog is wron » The install profile is sometimes referred to as a module during installation

Yeah, and in addition to the watchdog message, you can also see something like "Installed Minimal module" appear underneath the progress bar while the installation is taking place...

Both of those are a little strange.

catch’s picture

catch
he/him
Primary language English
commented

I've also spotted this, and agree it looks a bit odd.
yoroy did a screenshot:

Only local images are allowed.

aschiwi’s picture

aschiwi commented
Priority: Normal » Minor

I just played around with install profiles and I saw what is shown in #2 every time I installed. Whatever the name of your install profile, it's displayed there ("installed [profilename] module") and it's always the last step. Any ideas if this can be fixed?

rjgoldsborough’s picture

rjgoldsborough commented
Status: Active » Needs review
StatusFileSize
new d7_profile_installed_notification.patch664 bytes

This patch checks to see if the module being installed is a profile, and if it is, says "Installed %profile profile" instead of "Installed %profile module"

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

Since this involves a new string, I think we should move it to Drupal 8. It's not a serious enough bug that it's worth breaking translations for, in my opinion.

The approach in the patch looks very reasonable, but this part:

+    $context['message'] = st('Installed %profile profile.', array('%profile' => ucfirst(drupal_get_profile())));

drupal_get_profile() returns the machine-readable name, so we don't want to display that. Can't you just continue using $module_name here?

rjgoldsborough’s picture

rjgoldsborough commented
Status: Needs work » Needs review
StatusFileSize
new d7_profile_installed_notification.patch647 bytes

Yeah, $module_name can be used here and this updated patch reflects.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

This should also update the watchdog call, right?

rjgoldsborough’s picture

rjgoldsborough commented
Status: Needs work » Needs review
StatusFileSize
new d8_install_profile.patch2.08 KB

Why yes it should. Here is an updated patch.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, and I tested that it works. So... RTBC for Drupal 8 :)

dries’s picture

dries commented

Just a heads up: I'd like to commit #1136130: Regression: Reinstate WATCHDOG_* constants and document why they are necessary. first. The patch in #4 will have to be re-rolled for D8 after #1136130 lands.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Needs backport to D7

tagging.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -Needs backport to D7

#8: d8_install_profile.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8_install_profile.patch, failed testing.

rjgoldsborough’s picture

rjgoldsborough commented
Status: Needs work » Needs review

#8: d8_install_profile.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs backport to D7

The last submitted patch, d8_install_profile.patch, failed testing.

rjgoldsborough’s picture

rjgoldsborough commented
Status: Needs work » Needs review
StatusFileSize
new install-profile-is-referred-to-module-during-installation-689396-16.patch2.09 KB

Rerolled for d8.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

Looks good, and seems to work perfectly.

chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs work

Use string overrides hack if you need to be dont add code executing once to module_enable which loads all the time a Drupal site exists. I feel we care less about bloat than we did before but this is really ick.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

I thought there was an issue for reverting the whole install-profile = module blur, which would allow to solve this much cleaner, but I can't find it right now.

rjgoldsborough’s picture

rjgoldsborough commented

So the issue is the if statements in the module_enable function?

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Needs review

@chx, I think you're fighting the symptom here rather than the cause. There is much more complicated code already in core to support the whole "install profiles are modules but not really" concept, and it makes the simple if statements introduced by this patch look like child's play. (For example, check out _system_rebuild_module_data()...)

As stated above, there's another issue for dealing with the overall problem. Or if not, there should be - I thought there was but couldn't find it either (there's some discussion of it in #820054: Add support for recommends[] and fix install profile dependency special casing definitely, but it's not quite the main focus).

Let's make sure an issue for that exists, but I don't see any reason to hold up a simple bugfix for it. (If nothing else, it helps give an accurate count of how many if ($module == $profile)-type lines the current system requires us to have, and therefore helps determine the urgency of doing it in a better way.)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

To fix the cause, I created #1676196: Install profiles are registered as modules

alansaviolobo queued 16: install-profile-is-referred-to-module-during-installation-689396-16.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 16: install-profile-is-referred-to-module-during-installation-689396-16.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Closed (outdated)
Issue tags: -Needs backport to D7 +Bug Smash Initiative
Related issues: +#1676196: Install profiles are registered as modules

This no longer happens. Certainly not on Drupal 9.4 which I just installed today via the web UI. There is an existing issue for dealing with the profiles as modules.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!