New add-on Module - Multiple Image upload

Hi Dirk,

Error message mentioned on the other post when trying to load drag n drop. I copied the unzipped imagex folder to the contrib folder under node gallery, then installed it as per usual. Then i went to one of my galleries (one without slideshow plug in - standard node gallery installation)

Java verified working by java.com

Have I put it in the wrong place??

cheers joe

Java Plug-in 1.6.0_17
Using JRE version 1.6.0_17-b04 Java HotSpot(TM) Client VM
User home directory = C:\Users\Joe
----------------------------------------------------
c: clear console window
f: finalize objects on finalization queue
g: garbage collect
h: display this help message
l: dump classloader list
m: print memory usage
o: trigger logging
q: hide console
r: reload policy configuration
s: dump system and deployment properties
t: dump thread list
v: dump thread stack
x: clear classloader cache
0-5: set trace level to
----------------------------------------------------

load: class Main.class not found.
java.lang.ClassNotFoundException: Main.class
at sun.plugin2.applet.Applet2ClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at sun.plugin2.applet.Plugin2ClassLoader.loadCode(Unknown Source)
at sun.plugin2.applet.Plugin2Manager.createApplet(Unknown Source)
at sun.plugin2.applet.Plugin2Manager$AppletExecutionRunnable.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: java.io.IOException: open HTTP connection failed:http://www.avocet-designs.co.uk/isy/Main/class.class
at sun.plugin2.applet.Applet2ClassLoader.getBytes(Unknown Source)
at sun.plugin2.applet.Applet2ClassLoader.access$000(Unknown Source)
at sun.plugin2.applet.Applet2ClassLoader$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
... 7 more
Exception: java.lang.ClassNotFoundException: Main.class

Hi Dirk,

Had a quick go and no joy - I'll have another go at it tomorrow - think i'll have to delete all database entries before re-install - i will let you know the progress...

cheers, joe

Dirk,

I gave the module a test run and was successful. One mod that would be nice is if I were able to view the images that I want to upload as thumbnails instead of just list or detail, but I guess thats what the drag and drop feature solves. The other problem is that when I upload photos it isn't saving them to the gallery directory for how I configured the pictures to be saved (%username/%gallery_name) the pictures are saved to mysite/files/. Other than that it is great to be able to bulk upload images now!!!!!!

Sven

It's neat! Works very well. Nice work Dirk, you are a wizard......

observations:
* image storage directory issue #4
* drag n drop also uses list or details #4
* mouse scroll action on entire page is disabled, have to use scroll bar

feature request:
* possible to choose bulk or individual image upload from upload images page..
maybe ahah function choose option.?
or
maybe additional node_gallery tab.?
view | manage images | sort images | upload images | bulk upload | edit

EDIT: this test using file from post #1, OP

#5 images not uploaded

images show in list, but no image is uploaded.
notice after upload:

The following images have been uploaded to this gallery.
Manage your Images here

Does not show any thumbnails.. as the module from #1 does.

this is code from pages inc..
maybe the module can't find the function.. node_gallery_check_directory

function node_gallery_check_directory($gallery) {
  global $user;
  $gallery_directory = strtr($gallery->config['gallery_directory'], 
     array('%uid' => $user->uid, '%username' => $user->name, '%gid' => $gallery->nid, '%gallery_name' => $gallery->title));
     
  $gallery_directory = node_gallery_validate_filesystem_path($gallery_directory);
  
  $directory = rtrim(file_directory_path() .'/'. $gallery_directory, '/\\');
  //recursive mkdir;
  if (!is_dir($directory)) {
    mkdir($directory, 0777, TRUE);
  }
  file_check_directory($directory, FILE_CREATE_DIRECTORY | FILE_MODIFY_PERMISSIONS);
  
  return $directory;
}

I added the code from #8 to the module file(changed return $dest), seems to work, images show up, but still the directory isn't right.. hmmm

// Get the path to your Gallery directory 
 ................................................................................
  file_check_directory($directory, FILE_CREATE_DIRECTORY | FILE_MODIFY_PERMISSIONS);
 
  return $dest;
}

EDIT: scratch all that,, not the right way to do it. someday I will learn this stuff

well, it seems to work now, all files still in /files
I don't know why it did work at first.. cleared caches, ran cron for fun.. maybe my firefox beta was messing up. I went back to FF3.5.6
The scrolling works now too..

Hi Dirk,

Tested on different website on different server - installed in modules dir rather than contrib and all works fine - nice job!

One suggestion would be to include a link back to the old method of uploading in case of issues - I've noticed a few of the bigger sites seem to do this on their Javascript image upload features - eg facebook and ebay.

Thumbnails display sticks to 100 x 100? - I cant see this being a problem though...

Many thanks! its a very nice feature and well put together too!

cheers, joe

this may be a wamp issue.. it makes the %gallery_name, but it's not a directory, it's a file, all code:
short sample
ÿØÿà

EDIT: I didn't delete the module, let me play a with it some more

well, it's not making a directory.
the files are raw code, but they do open with image viewer.

When I try to use %gallery_name, or any other gallery tokens, it give me error.. the error is not on upload page. The error shows on gallery list page..after upload is attempted..
When I use custom directory name 'galleries' nothing happens, images in /files/

weird stuff, but this is really neat function

it's something with 'mime type' or 'extension'. If i rename a 'raw file' with .jpg ,, it shows in file system as normal

No rush. no problem. Your family and kids are far more important than Drupal

Woot, Woot, Yipee, It's awesome work Dude !!!
Ready for a release...

Your the man..
Thank you Dirk

Node Gallery is really rockin now buddy..

Hi,
Dont know if you saw the other post but there seems to be an IE8 issue with the Galleriffic slideshow of node display?

Drag n drop looking good!

Joe

Note to self for readme:
document that you must choose a cover image on manage images page manually.

Dirk,

Just gave the latest update a test run, and it uploaded the pictures to the gallery under the user name, but it created a new gallery name. I have a gallery called 2nd Test. Before the bulk upload module node gallery created a directory called 2nd_Test where the original pictures were uploaded. With the bulk upload module the pictures were put in a directory called 2nd\ Test leaving the space in. Also when uploading files the extension types listed at the top differ from the ones in the window that pops up. The popup window add png and bmp. I attached a screen shot.

Thanks for this add on module!!!

Sven

The node gallery settings have a place for allowed file types.

node_gallery_imagex.module has to edited to match the setting you used in node gallery.
@@ 108
<param name = "fileextensions" value = "Image Files,jpg,gif,jpeg,bmp,png" />
--------------
The issue is someplace here, but so many issues have multiple fixes, can't find it now.
peg_replace was updated in node_gallery.module
$validated_path = preg_replace('/[^a-zA-Z0-9._\/]/', '', str_replace(' ', '_', .................

imagex.module
@@ 248
$validated_path = preg_replace('/[^a-zA-Z0-9._]/', '', str_replace(' ', '_', $gallery_directory));
change to:
$validated_path = preg_replace('/[^a-zA-Z0-9._\/]/', '', str_replace(' ', '_', $gallery_directory));

Hope that helps...

EDIT: June 23rd, 2010...The demo has been disabled, see last post in this thread

Here is demo
http://www.davebeall.com/node-gallery-imagex

nice work, tested, all is well that I can see.
Thank you Dirk

Dirk,

Just finished another test, this time a directory was created as 2nd_Test/, where node gallery is configured to put pictures in /2nd_Test/.

Sven

oh I forgot, in my copy I added the preg_replace update that Justintime added to the node gallery module.
preg_replace('/[^a-zA-Z0-9._\/]
it has the fore slash and back slash added \ /
maybe that's why it worked for me...

Hey Dirk,

I wanted to thank you. #24 is working for me perfectly. It is a brilliant solution for a project I am working on. I am testing this module even I am so close to finish development and migrate to production for this project. I want to replace existing configuration with this.

When are you planning to move it its own project page? I'd like to contribute where I can.

Thanks,

Osman

Sounds great Dirk.

I'll hold until licensing issues are cleared.

Cheers,

Osman

@Sevn, are you adding slashes in the gallery configuration..
no prefix slash and no suffix slash
it should be:
2nd_test

with a longer path it would be:
2nd_test/galleries/%username/%gallery_name

edit: sorry, got your name wrong Sven

dbeall & Dirk,

I had originally created two galleries with node gallery the first called Testing and the second one was called 2nd Test. I configured node gallery directory setting to be %username/%gallery_name. I uploaded some files with the node gallery upload b/c Dirk hadn't written this awesome module yet. The directories were successfully created and the images were put into the correct directories. Now I don't know if I should have created a new gallery to use the bulk upload tool with, but maybe that's what I need to do. I will try that out in a little bit. I also use Postgres for the DB not sure if that even has anything to do with this. I have attached two screen shots for review, one of the node gallery configuration and the other of the file structure. Did I possibly mess something while configuring?

Sven

@Sven, you got me on the Postgres, I have no idea on that.(never used it)
Your node_gallery path configuration looks to be correct.
as far as make a new gallery.. I used it with existing gallery with no issues.

Created a new gallery called Corico which was a town I visited in Bolivia last year. I used the bulk upload module and it created a directory Corico. I attached a screen shot. Did I configure the the gallery directory wrong?

Dirk,

I updated to your latest code. I blew away my test site and rebuilt it today too. I still have the problem with the directory paths. I tried %uid/%gallery_name and %username/%gallery_name. Using the uid the directory created was 1, while the username was admin. Any ideas on why this is happening? If I don't use the bulk upload module the correct directory structure is created.

Great work Dirk,

Will try it out tomorrow and let you know how it goes,

cheers joe

I also tried rebuilding my test site using MySQL ad the DB, but I still am getting the same directory problems. Just wanted to see if that would change anything, but it didn't.

Dirk, thanks for all your amazing (and quick!) work. Something in your imagex modules is causing the file directories to be incorrect. I mistakenly thought it was due to this: http://drupal.org/node/670544#comment-2512044

I just uploaded your new module from comment #36. I tried uploading a single file with the hide bulk upload and the directory was created successfully and correctly:

galleries/%username/%gallery_name resulted in galleries/XOSO/Final_test_hopefully

Then I tried uploading four files with the bulk upload. The files were not put in the same directory, but instead, a new directory was created:

galleriesXOSOFinal_test_hopefully

I'm not sure where the error is but I wanted to let you know. Thanks for the great work!

I have the exact same issue. Also something else that I notice is that when you upload a photo not using the bulk option node gallery will pick a photo to be the cover of the gallery automagically. Using the bulk upload this doesn't happen and you have to choose the photo through the manage photos tab.

Choosing the cover image manually issue is known, the notice is on my demo, I thought it was in this thread, but I can't find it..
The directory is working fine here with default and imagex uploads,
I just upgraded node_gallery, node_gallery_access, node_gallery_display and node_gallery_imagex with the latest dev releases today.

side note, I am running transliteration

I updated node gallery to the one compiled on the 18th of Jan. Still having the directory problem though. If I don't use the bulk upload it works as I configured it. Then I installed the Transliteration module. THANK YOU DBEALL for mentioning this or anyone else who did and I failed to use this module. Installing the transliteration fixed the directory issue!!! Now I'm all set to bulk load, or that is until Dirk gets approval to go live with this module...

Dirk,

I will start testing your latest release ASAP. The hide check box works fine for me using IE8 and Firefox.

Sven

Just ran some testing and the module works excellent. One thing I noticed is that it doesn't say it depends on the transliteration module in the module list section. The hide bulk upload also worked fine too.

The module does not depend on transliteration, The "preg_replace" function is the fall back ' if ' transliteration does not exist.

We went through the preg_replace problem before, that is when Justintime added the \ / to the string.
I found the post..
http://drupal.org/node/670544#comment-2431938
cvs..
http://drupalcode.org/viewvc/drupal/contributions/modules/node_gallery/n...

I have been using transliteration by choice in every site that has uploads just to be sure file names do not have strange characters.

Forgive me for being redundant, but I don't have transliteration and would prefer not to have to install a module just to get a file directory named properly. I'm not a coder, but since it works with the single upload, is there nothing that can be changed to make the directory named correctly with the bulk uploader? I'm assuming it is otherwise you wouldn't say it's now dependent on the Transliteration module.

It would be great to not have to add another module just for this use. Dirk, is it even possible without Transliteration?

The hide bulk upload works with Safari too.

Thanks!

I was looking at the ImageCache project page and it calls for transliteration as a requirement.. I must have missed that too.. hmmm, I may need some stronger coffee
I have updated the front page of the Node Gallery Handbook

@Designwork, I don't know if it's possible or not, but you could just call node_gallery_validate_filesystem_path() from your module, and not have to worry about it. That way if we update that function in NG core, your module will get the benefit too.

Ok, thanks everyone. I'm not sure how, but I have ImageCache 6.x-2.0beta10 and on the admin/build/modules page it doesn't mention Transliteration, I've never had it, and it seems to work fine. Nothing on my admin/build/modules page mentions Transliteration at all. I also didn't see where it said it was required for Node Gallery. My mistake!

Hi, good work.
I have a problem. I created a gallery "A" with photos 1.jpg and 2.jpg. After, i created other gallery "B" with other photos named like gallery "A" (1.jpg and 2.jpg). I can't see new photos on gallery "B". I see the photos like gallery "A".

Any idea?

my solution:

replace this:
281 // Copy the file to the Drupal files directory
282 if(!file_copy($file,$dest)) {

for this:
281 // Copy the file to the Drupal files directory
282 if(!file_move($file,$dest)) {

Hey guys,

I seem to be having an issue with the action of multiple upload being completed as an Anonymous user. What I mean is that even though I am logged in as authenticated, it says that Anonymous is performing the action.

This makes it so I have to enable access to gallery uploads to Anonymous, which I don't want to. I also want to be able to view a log file that means something, so I want to find out why it is telling me things are being uploaded by Anonymous.

When I hide Multiple upload and just use the standard, this issue does not happen. It probably is something simple that I looked over, but any help would be wonderful.

Thanks in advance!,

Brandon

whoops.

@izarco: You can use the gallery tokens in your directory paths to eliminate this problem. For example, if I have gallery A and gallery B, I can use the path [parent-gallery-title-raw]/ (I'm shooting from the hip here, that's likely incorrect but you get the idea) in the gallery relationship settings, and the file 123.jpg will get created in files/A/123.jpg and files/B/123.jpg.

However, I don't know 100% that Dirk's module uses this path - I would assume so, but haven't set it up yet personally. @DesignWork, can you confirm?

I suppose it could happen if the images with same name goto the same gallery..
thinking out loud,, If so maybe a
if file exists, then append with alpha or numeric character

EDIT,, it seems to me that I have uploaded the same image 2 times before by mistake and it worked with NG and then I had to delete one,, after seeing it..

Does setting "Maximum resolution for uploaded images" in Image Gallery Relationship settings, affect this add-on module? I have a max resolution set, but when I use this add-on to upload images, only a handful of images get resized...

Also, postlet is giving me the following error randomly: "The selected file could not be copied, because no file by that name exists."

Dirk,

Yup, all users have multiple upload, and I am using user 1 to test it as well.
It gives me a page not found error from the postlet and I have no idea why.

Any suggestions?

This is working well and speeds up the upload process a great deal, thank you!

As a feature request/suggestion perhaps a cancel button would be useful (displayed during the upload progress)

Is this module going to be submitted as a new module, so it can benefit from it's own issue queue? or are you considering merging it with Node Gallery?

On line 101 of the version in #45

<param name = "destination"		value = "'.url('node_gallery_imagex/upload/' . $gid, array('absolute' => TRUE)).'" />

What do I need to set this to, so this module works with Drupal private file system?

I messed around with and the best I could get was a 404 error on

http://www.mydomain.com/http://www.mydomain.com/system/files/node_gallery_imagex/upload/45

I have the module installed at /sites/all/modules/node_gallery/node_gallery_imagex

Usually I get: The selected file /tmp/php8YAWWG could not be uploaded, because the destination is not properly configured.

@lonehorseend, the module is installed like all contributed modules at sites/all/modules
it should be sites/all/modules/node_gallery_imagex

It didn't matter what location . . . .either /sites/all/modules/node_gallery/node_gallery_imagex or sites/all/modules/node_gallery_imagex, I still couldn't get this module to work when I had the file system set to private. I didn't try setting it to public because public is not an option for me as I store all my data files outside of public_html for security reasons.

I just need to know if it will work with private and if so how do I configure it to do so? Image_gallery works fine in private mode without the bulk uploader.

Using the Add button under FF 3.5.7 works great!

I noticed, afterwards, that all my gallery images were showing up on the front page. This hadn't occurred using the normal upload method for Node Gallery, but the Gallery Image content type was set to promote to front page. So, Node Gallery must be unchecking that on upload. Easy enough to fix, but this might be a tweak to consider -- that the imagex upload method demote images from the front page -- to keep things consistent.

Edit: On further thought, I believe the way imagex is currently working is correct regarding setting the promoted flag on the uploaded images. Node Gallery is incorrect. The flag should be set on the content type, not by the upload method. No change should be made to imagex.

When using the bulk upload, you MUST manually choose a cover image after hitting the 'save' button.
If you do not, the gallery will show 0 images

I really don't understand. Is it possible to post a walk through, like this:

Install the module.
Browse to admin.
Click Create Gallery.
Fill in all fields.
Check bulk and select a zip file.
Select an album front image.
Press save?

Or the same, where you name one of the images 'album front'?
Or, do you create the gallery and upload one image, then do a bulk upload?

I kept getting .js scripting errors after I installed this, from my site.
A possible way to fix the 'must have an album cover' is to make it so that a folder is created for a gallery upon gallery creation rather than upon the first image's upload.
OOPS! I have another error to report, also. I'm so bad at sorting. Oh well. Tag it.

Here goes:
When you upload an image, then browse away from the uploaded image page without saving, then browse back..., your progress will be gone. So, you try to re-upload the images to create a new gallery item. Naturally, when you upload a duplicate to your server, like name.jpg twice, it names the second one name1.jpg and the third name2.jpg, and ... namen.jpg where n is the number of uploads of the same image. But node gallery tries to link to name.jpg, no matter how many times you upload that same file, and you end up with dead image links except for the thumbnail. So, if ten people want to upload pictures of their dalmation, and they all upload dalmation.jpg, you're going to have a bunch of pages with no full-screen image and only the first dalmation.jpg image name upload will work.

enjoi, I can't fix this, but I know that you can just go to the files/galleryid directory on your drupal site and delete the dupes and start over.

Using #45, this is what I get:

    * The selected file /private/var/tmp/php0WLjmr could not be uploaded, because the destination is not properly configured.
    * warning: stat(): stat failed for /private/var/tmp/Municipal Building2 Jan 19 1968.jpg in /Users/homer/Sites/nypap/sites/all/modules/node_gallery_imagex/node_gallery_imagex.module on line 242.
    * The selected file could not be copied, because no file by that name exists. Please check that you supplied the correct filename.
    * The selected file /private/var/tmp/php0WLjmr could not be uploaded, because the destination is not properly configured.
    * warning: stat(): stat failed for /private/var/tmp/MunicipalBuilding Jan 19 1968.jpg in /Users/homer/Sites/nypap/sites/all/modules/node_gallery_imagex/node_gallery_imagex.module on line 242.
    * The selected file could not be copied, because no file by that name exists. Please check that you supplied the correct filename.

The selected images are not coming from the private directory!

When I deselect the bulk upload and use the standard upload it works just fine...

I've looked over this whole list and not seen anything like this, which makes me suspect a configuration issue with my own computer. I'm running a regular amp stack on OS X 10.6.3 with PHP 5.3.2.

Similar issue to #75 just without the private

# The selected file /var/tmp/phpVG6nyD could not be uploaded, because the destination is not properly configured.
# warning: stat() [function.stat]: stat failed for /var/tmp/IMG_0103.JPG in /home2/campshom/public_html/drupal/sites/all/modules/node_gallery_imagex/node_gallery_imagex.module on line 242.
# The selected file could not be copied, because no file by that name exists. Please check that you supplied the correct filename.

I'm wondering if there is a specific way to set the destination folder that would not create this error.

I received a security announcement today about the imagex module.
This was not for node_gallery_imagex, but the node_gallery_imagex module hasn't been formally posted as a drupal module, therefor it doesn't get a security audit.
The security announcement did not specify exactly what the issue is other than it's vulnerable to access bypass.

I would say this means, use at your own risk.

* Advisory ID: DRUPAL-SA-CONTRIB-2010-070
* Projects: Multiple third party modules - Easy Translator, Block Queue,
Multiple Image Upload (Imagex)
* Version: 5.x, 6.x
* Date: 2010-06-23
* Security risks: Critical
* Exploitable from: Remote
* Vulnerability: Multiple (SQL Injection, CSRF, Access bypass)
-----------------
Multiple Image Upload (Imagex) [3] for Drupal 5.x and 6.x
The Multiple Image Upload module enables images to be "drag 'n' dropped"
uploaded into Drupal. The module is vulnerable to access bypass.
*Solution:* Disable the module. There is no safe version of the module to
use. All releases of the module were marked unsupported earlier.
-----------------
* Multiple Image Upload (Imagex) issue reported by Greg Knaddison [7] of the
Drupal Security Team

I use module node_gallery_imagex with module transliteration 6.x-3.0-rc1
Filename don't transliterate.
Please help.

Using #45, I ran into to two problems.

I set the Gallery Directory to 'gallery/%gallery_name' to organize the galleries to subfolders. Using the Imagex multiple uploads the subfolders were not created, but a 'gallery%gallery_name' directory was created for the uploaded images.

I managed to find and mend the issue by adding '/' to the permitted characters in the path:

 diff node_gallery_imagex.module.ori node_gallery_imagex.module
260c260
<     $validated_path = preg_replace('/[^a-zA-Z0-9._]/', '', str_replace(' ', '_', $gallery_directory));
---
>     $validated_path = preg_replace('/[^a-zA-Z0-9._\/]/', '', str_replace(' ', '_', $gallery_directory));

Clean URLs are not available on the server I try to set this up and the link to the postlet.jar turned to be this which returned 404 error:

/?q=sites/localhost.dpzugweb/modules/node_gallery_imagex/postlet/postlet.jar

I found that it is the Drupal url function which adds the '?q=' to the URL when clean URL is turned off, but I don't know what would be the proper fix for this. I ended up hardcoding the path to get me going.
If you know a fix for this please share.

diff node_gallery_imagex.module.ori node_gallery_imagex.module
97c97
<       <applet name="postlet" code="Main.class" archive="'.url(drupal_get_path('module','node_gallery_imagex').'/postlet/postlet.jar', array('absolute' => TRUE)).'" width="100%" height="300" mayscript>
---
>       <applet name="postlet" code="Main.class" archive="http://www.site.com/sites/all/modules/node_gallery_imagex/postlet/postlet.jar" width="100%" height="300" mayscript>

clean URL's is required for the imagecache to work.

the preg replace was fixed in node_gallery, but needed the slashes in the imagex module..

hey, is this stable yet?

I can't comment on whether or not it's stable, but I can tell you it's un-maintained. This feature is implemented in the core module in Node Gallery 3.x and it's integration with plupload. No new features will be introduced in the 2.x branch.