AJAX views try to scroll the wrong element when clicking a pager element. [#689780]

Currently, if a view is ajax-ified, it tries to scroll the body object so that the top of the view is viewable. This means that if the view is embedded inside of a popup, it will scroll the body instead of the popup container. This patch searches for the first element containing the view that needs scrolling, and scrolls that instead.

This is also an issue in the 2.x branch.

Comment	File	Size	Author
#4	ajax_views_scroll_target.patch	2.12 KB	dawehner
#4
	ajax_views_scroll_target.patch	1.49 KB	deviantintegral

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 12 March 2010 at 18:50

I would like some testing to ensure this doesn't break anything? It looks ok to me, I'd just like to be sure.

Comment #2

deviantintegral CreditAttribution: deviantintegral commented 15 March 2010 at 20:31

For anyone wanting some steps to test this issue:

Create a view with a reasonable amount of content; all nodes or users should be simple enough.
Enable the pager for the view, and ensure that the view when loaded will have more than one page.
Enable AJAX loading for the view.
Install the popups module. Alternative modules for overlays should work as well, though this is the one I used at the time.
Popup-enable a link to the view. This is probably best done by enabling the popups module on all pages in it's settings, and creating a link such as:<a href="/path/to/view" class="popups">View in popup link</a>
Use the pager in the view while it is rendered in an overlay. Best seen if you scroll down the page a few paragraphs before activating the popup.