user_reference_user_load() expected to be a reference

Moving issue to the correct project.

Move to new References module.

Categorizing.

Cannot reproduce on PHP 5.3.3, Drupal 7 RC1 and the current version of user_reference. Can you provide a scenario to cause this problem ?

In the current code, the user_reference_user_load() function is commented out.

However in the commented out code, there is no reason why the $accounts parameter should be prefixed with &. I believe the $accounts array is an array of references, so this isn't needed?

<?php
function user_reference_user_load(&$accounts) {
?>

See profile_user_load() as an example. The parameter does not use references, but it still manages to alter the objects with no problems:
http://api.drupal.org/api/drupal/modules--profile--profile.module/functi...

This is likely also true of the hook_user_view() implementation directly beneath it.

$accounts should not be prefixed with '&'

Patch for commented function

These functions, as they currently are, no longer make sense. Removing the useless ampersand does not make hook_user_view() compliant with the D7 API, and they are commented out anyway. I committed just the signature changes for that API compliance, but these functions need to be reworked or removed anyway.