workflow.pages.inc, line 181:

$output .= drupal_get_form('workflow_tab_form', &$node, $wid, $states, $current);

With the function defined on line 120:

function workflow_tab_form($form_state, $node, $wid, $states, $current) {

The workflow_tab_form() function needs $node to be a reference.

The error:

	Parameter 2 to workflow_tab_form() expected to be a reference, value given in /var/www/html/includes/form.inc on line 372.

There are two possible solutions
1) If and only if $node is not changed in anyway, then the reference can be removed from the function definition. (an easy fix or a temporary "silence the error" fix)
2) fix the function call at line 181 such that $node gets passed as a reference. (the hard but often correct fix)

CommentFileSizeAuthor
#4 workflow_690860_param_ref_warning_4.patch768 bytesdooug

Comments

Skorpjon’s picture

Skorpjon commented

subscribe

XerraX’s picture

XerraX commented

can you make a patch?

jvandyk’s picture

jvandyk commented
Status: Active » Fixed

Fixed in 6.x-1.x-dev. I don't see anywhere that the node is modified, so I have modified the function definition to remove the reference.

dooug’s picture

dooug commented
StatusFileSize
new workflow_690860_param_ref_warning_4.patch768 bytes

Right, I just ran into this. I see you've committed it to dev, but here is the patch that solves the issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

astra’s picture

astra commented

My site under D5 got the same problem after upgrading to php5.3:

warning: Parameter 1 to workflow_tab_form() expected to be a reference, value given in .../includes/form.inc on line 218.

Go to workflow.module and try to change the line

function workflow_tab_form(&$node, $wid, $states, $current) {

with this (just removed "&")

function workflow_tab_form($node, $wid, $states, $current) {

It seems to fix the problem.