Posted by Zoltán Balogh on January 21, 2010 at 12:25pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | markup |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Novice |
Issue Summary
There is a typo in the blog.module: a href='@blog''
Comments
#1
There are quite a few other places in core with
<a href='foo'>- will try to patch'em all soonish.#2
This is an excellent opportunity for new contributors, so tagging it with Novice.
#3
I am fresh to drupal open source. Can we attach our patch on the same page with comment ?
I have read some pages but unable to find this information.
#4
Patch is on the way, i'm already working on it; expect results in ~10 mins.
#5
Sorry for the delay, CVS is like a snail here.
I haven't touched
jquery.jsnorcomment.testas I don't know whether it's a bug there as well.#6
Did you try the patch?
This simply won't parse:
<?phpt('The Blog module allows registered users to maintain an online journal, or <em>blog</em>. Blogs are made up of individual <em>blog entries</em>. By default, the blog entries are displayed by creation time in descending order, with comments enabled, and are promoted to the site's front page. For more information, see the online handbook entry for <a href="@blog">Blog module</a>.
?>
As single quotes are perfectly valid as attribute value delimiters, why not just use '@blog' ? If you do want to use double quotes, either escape (\") them, or use a single quote delimited string and escape the lone single quote (\') after site
#7
@qasimzee: Welcome to Drupal :)
So when someone creates a patch then writes a comment with the attached .patch file. (Below the comment's textbox you can see a 'File attachments' form element.)
Also it's a common practice to change the issue status to CNR (code needs review) whenever a new patch is attached so the test bot will automatically run its tests to find out if that patch breaks something in Drupal's core.
#8
@Heine in #6: Thanks for pointing me at that tyop; look's like I should set up my own testbot environment. :S
Corrected (and tested) patch is attached.
#9
@Boobaa: I really don't understand why you're changing all single quotes to double ones. As Heine already mentioned above, single-quoted attribute values are perfectly ok. Source: http://dev.w3.org/html5/html-author/.
So I'd suggest focusing only on the original typo.
#10
Attached is the patch which solves OP, without disturbing the force more than needed. Sorry for the already-done disturbances.
#11
#10 is OK
#12
@zserno: Thanks a lot for your guidance
#14
Committed to CVS HEAD. Thanks!
#15
Automatically closed -- issue fixed for 2 weeks with no activity.