Allow feature hooks to be more specific

I think is this is definitely useful, but I wouldn't want to restrict the functionality to views and would want it implemented differently.

skinr[x][features][] is where I think this belongs. This is really just the theme hook (we should probably change the name of this to just "hook" because it's kind of confusing). Anyway, here's where I'm going with this...

Let's say you only want to use a style on menu blocks and views lists.

Instead of:

skinr[some_skin][features][] = views_view
skinr[some_skin][features][] = block

We should be able to do:

skinr[some_skin][features][] = views_view_list
skinr[some_skin][features][] = block_menu

Both of the above are actual theme hooks, i.e. corresponding template files and make more sense.

Because of some limitations in knowing the hooks before page render happens (i.e. when you're editing skinr settings), I've implemented a reduced subset of more specific hooks.

blocks module: block_[module], block
comment module: comment_wrapper_[node_type], comment_wrapper
views module: views_view__[view_name]__[display_name], views_view__[display_name], views_view__default, views_view__[view_name], views_view

If we need any more, we're going to have to add code for them. Let me know.

Committed to CVS.

Hey, so I just tried this out and noticed we are missing the view styles here (which are the most important, IMO):

• views_view_list
• views_view_grid
• views_view_table
• views_view_unformatted
• views_view_jump_menu

It should also be able to pick up styles provided by other modules, like jQuery UI carousel, Views Rotator, etc. if possible.

So... views_view_[style]

Also, for the sake of being consistent, it should be done for nodes too:

node_[node_type]

Ok, and as I write documentation the rest comes to me... LOL. Here's the full (final) list all in one place:

Blocks

skinr[skin_system_name][features][] = block
skinr[skin_system_name][features][] = block_[module]

Comment

skinr[skin_system_name][features][] = comment_wrapper
skinr[skin_system_name][features][] = comment_wrapper_[node_type]

Nodes

skinr[skin_system_name][features][] = node
skinr[skin_system_name][features][] = node_[node_type]

Page (Body Classes)

skinr[skin_system_name][features][] = page

Panels

skinr[skin_system_name][features][] = panels_pane
skinr[skin_system_name][features][] = panels_panel

Views

skinr[skin_system_name][features][] = views_view
skinr[skin_system_name][features][] = views_view__[style_name]
skinr[skin_system_name][features][] = views_view__[display_name]
skinr[skin_system_name][features][] = views_view__[view_name]
skinr[skin_system_name][features][] = views_view__[view_name]__[display_name]

You missed the following:

skinr[skin_system_name][features][] = panels_display
skinr[skin_system_name][features][] = views_view__default

I'm not sure why views isn't returning the style based names (we're using views' function to return those derived hooks). I'll try and figure it out.

Just looked at this further, and found the following: Our skinr styles are currently being applied to the views_view hook. views_view_[style] refers to the row style, which is a different hook all together, so we would never get the derived hooks that include style.

In order to get that working, we're going to have to add more layers of skin-able parts for views (like panels has panels_display, panels_panel, panels_pane). But that would be a whole separate issue. Opened a new issue #732592: Add support for views row style.

Committed node_[node_type] hook code to CVS.