Improve RDF tests [#691692]

Comment	File	Size	Author
#12	rdf_improve-test_691692-8.patch	6.33 KB	cwgordon7
#10	rdf_improve-test_691692-6.patch	6.33 KB	stefan freudenberg
#9	rdf_improve-test_691692-5.patch	6.35 KB	stefan freudenberg
#7	rdf_improve-test_691692-4.patch	6.36 KB	stefan freudenberg
#5	rdf_improve-test_691692-3.patch	6.35 KB	stefan freudenberg
#2	rdf_improve-test_691692-2.patch	4.06 KB	linclark

Comment #1

Anonymous (not verified) commented 21 January 2010 at 16:35

Assigned:

Unassigned

» linclark

Unless you're already working on this, I can work on this tomorrow.

Log in or register to post comments

Comment #2

Anonymous (not verified) commented 24 January 2010 at 23:57

Status	File	Size
new	rdf_improve-test_691692-2.patch	4.06 KB

This patch replaces all the assertRaw statements with XPath checks. It also checks the title in full node view by checking the content attribute of the meta tag.

I am going to break the test for the relation between a comment and its parent node and parent comment into a separate issue because that test will fail until some other patches are committed.

Log in or register to post comments

Comment #3

Anonymous (not verified) commented 25 January 2010 at 00:03

Status:

Active

» Needs review

#694314: RDF tests for parent/comment relationship has been created.

Log in or register to post comments

Comment #4

scor commented 7 February 2010 at 16:13

Status:

Needs review

» Needs work

#694314: RDF tests for parent/comment relationship now duplicate since we now have proper RDFa markup for comment body. Tests can be merged with this issue.

Log in or register to post comments

Comment #5

stefan freudenberg commented 21 April 2010 at 05:41

Status	File	Size
new	rdf_improve-test_691692-3.patch	6.35 KB

Added tests for the relation between a comment and its parent node and parent comment and removed trailing whitespace.

Log in or register to post comments

Comment #6

scor commented 21 April 2010 at 05:55

+++ modules/comment/comment.test	21 Apr 2010 05:39:21 -0000
@@ -1166,6 +1166,10 @@ class CommentRdfaTestCase extends Commen
+    $result = $this->xpath("id('comments')//div[@class='comment' and position()=0]//span[@rel='sioc:reply_of' and @resource=:node]", array(':node' => url("node/{$this->node1->nid}")));
+    $this->assertEqual(1, count($result), t('Assert RDFa markup referring to the node is present.'));
+    $result = $this->xpath("id('comments')//div[@class='comment' and position()=0]//span[@rel='sioc:reply_of' and @resource=:comment]", array(':comment' => url('comment/1#comment-1')));
+    $this->assertFalse($result, t('Assert no RDFa markup referring to the comment itself is present. '));

Let's bundle this first hunk into the new function you create afterwards.

Powered by Dreditor.