Active
Project:
Node Gallery Display / jquery slideshows for node_gallery
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
21 Jan 2010 at 17:56 UTC
Updated:
31 Mar 2011 at 22:56 UTC
Jump to comment: Most recent file
Comments
Comment #1
designwork commentedHi Joe,
I do not have IE8 on any computer (MAC user). I will have to get a Comptuer with IE8. Can you check if this is only IE8 or also IE7 and 6.
Cheers
Dirk
Comment #2
dbeall commentedall I have is IE6 and it has same error. Microsoft seems to always be a problem child...
I looked at the latest .js from galleriffic and historyinit is being used.
A google search turned up the possible problem. historyinit has to be history.init
But I don't know any programming.. that's what they were saying.
Comment #3
joecanti commentedHi dirk,
Thanks for the quick reply..Testing results:
IE6:
Ad Slider is fine (only minor issue is there is no white background behind caption on adslider)
Easy Slider works fine
Galleriffic - clicking thumbs does not do anything - line: 352 char: 9 Object doesnt support this property or method.
Tested this on 2 different sites.
I cannot get IE7 to load up at the moment - will keep trying and let you know.
Not sure what the set up is on a mac but we cannot run 2 versions of a browser eg IE6 & IE7 on the same machine on a PC so I tested it at www.spoon.net/browsers - i think this is pc only as it installs a plug in - there may be a mac version out there somewhere.
Cheers, Joe
Comment #4
dbeall commentedThis is weird.. Goto the demo site for galleriffic with IE and it works
http://www.twospy.com/galleriffic/example-3.html
Comment #5
joecanti commentedok
Tested in IE7 now and the same problem comes up...
Found this great little app: http://www.my-debugbar.com/wiki/IETester/HomePage
Saves me lots of time on browser sandboxes etc - again, not sure about a MAC version - think its only possible with VMWare.
cheers, Joe
Comment #6
designwork commentedHi Joe,
try this one (fast fix). rename the file and copy it to your js/full folder. Make a copy of the old one first.
Dirk
Comment #7
joecanti commentedthanks Dirk,
There is a syntax error on line 21 but ignoring this it now works! when clicking thumbnails in IE7 and IE8 the image changes...
In IE6 the thumbs do not show up, but clicking the space where they should be makes the image change also.
cheers, joe
Comment #8
designwork commentedHi Joe,
what do you mean with syntax error? Can you post the error message! As I do not have IE8 I can not reproduce it.
Dirk
Comment #9
joecanti commentedSorry - I should have mentioned - Dreamweaver popped up with the Syntax error. The error disappears when the . is removed from hisory.innit on line 21
The IE errors are the same as before...
cheers, joe
Comment #10
designwork commentedDear Joe,
before you moved the "dreamweaver syntax" error it worked on IE8 right?
If yes let the dot where it was.
If not we start again.
Comment #11
dbeall commentedwell, I tried the file and it broke the gallery in FF and IE6,
shows all the thumbnail images with the captions, and when clicked they opened full image.
Comment #12
dbeall commentedthere is another call to that function $.historyInit in jquery.galleriffic.js @@ 868
there may be some others..
EDIT: I tried renaming the other calls to the function.. no luck
Comment #13
joecanti commentedhi Designwork,
sorry for the slight delay - here is what i did:
I used dreamweaver to create the js file from your text file (just renamed it) but noticed that dreamweaver picked up on a syntax error. I ignored this error, saved and copied the .js to the right place - when opening up the gallery it worked - the thumbs were bringing up the main images - but the previous error was still coming up plus a scripting error, which I imagine was refferring to the syntax error found by dreamweaver.
Here is what IE says as the errors:
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Win64; x64; Trident/4.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Sat, 23 Jan 2010 20:21:52 UTC
Message: Expected ':'
Line: 21
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/sites/all/modules/node_gallery/contr...
Message: Expected identifier
Line: 47
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/?q=node/31
Message: Object doesn't support this property or method
Line: 281
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/?q=node/31
Unfortunately IE doesn't give much away - and the problem doesn't seem to exist with any other browsers. Its annoying that IE is at the source of most cross browser issues - you are lucky to be on a MAC!!
cheers, joe
Comment #14
dbeall commentedI have been playing with this..
Try removing the jquery.history.js file completely and it works for me
It's something to do with the on click event.?
maybe here.?
$("a[rel='history']").live('click', function()Comment #15
dbeall commentedI will pull it out of my demo real quick
Comment #16
dbeall commented@joecanti, can you try it
http://www.davebeall.com/node-gallery4/galleriffic_photo_gallery
Comment #17
dbeall commentedjQuery.history plugin integration to support bookmark-friendly URLs per-image rather than one URL using the gallery name for all images
Comment #18
joecanti commentedhi dave,
Works on IE6, IE7 and IE8..
Still has the original error as below...but only 1 error and not 3
Does the file you removed just deal with the hstory, or os there more to it than that?
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Win64; x64; Trident/4.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Sat, 23 Jan 2010 22:16:38 UTC
Message: Object doesn't support this property or method
Line: 348
Char: 9
Code: 0
URI: http://www.davebeall.com/node-gallery4/galleriffic_photo_gallery
(this error is just the one that appears down the bottom left of IE as the yellow warning triangle but doesnt seem to affect operation whatsoever!)
cheers, joe
Comment #19
dbeall commentedThe history thing is just to generate a unique URL in the address bar for each image, rather than the same URL for all images in the gallery. But the xmlsitemap still shows all the individual images.
I didn't notice the error, it just was working.
there were a lot of people on the web hunting for the answer to this error..
some of it was click event, some was a naming issue, and the list goes on and on.. Much of it was over my little brain.. ug..
Comment #20
designwork commentedHi dbeall,
nice chatch, I will make a browser ceck and if we have an IE browser we remove the history.js.
Thanks
Dirk
Comment #21
dbeall commentedthere is one other thing, but I'm not sure.
If you book mark the image when viewing the galleriffic gallery and follow the bookmark back to the site, ?? I think it will open galleriffic to view the image..??
I would have to test that part to see what it does.
If the image URL is followed from the xmlsitemap URL, it will open the image in a default node_gallery gallery.
But I don't see the xmlsitemap creating the fragmented URL like the history plugin does...
it is just normal Drupal, URL alias path.
I think I have to look closer at this...
Comment #22
designwork commentedHi All,
here comes a new version of the module. It will check the browser and insert different js for each browser, if necessary.
But it will also display a message on galleriffic galleries to change the browser and get a descent one.
I can remove this message. But IE sucks!!!
Cheers
Dirk
Comment #23
dbeall commentedI hate to add this,, but......
function node_gallery_display_get_browser($useragent){
--is not working in my test.--
lots of discussion about this function on the net..
Ran across this page on Drupal
http://drupal.org/node/65903
Comment #24
designwork commentedHi dbeall,
Hm do you think this is a caching problem. The function on node 65903 is not the same as mine. But we can test it more. I will do a simple test on my test page. http://photographer.freelens.ws
There anybody going to http://photographer.freelens.ws/galleries and then choose a gallery will see a message with his browser and the version of it like:
Your Browser is Firefox Version: 3.0.3
Your Browser is Safari Version: 532.5
Your Browser is Safari Version: 531.21.10
Your Browser is other Version: 0
One Problem is for example, that Chrome pretends to be Safari and that Opera, depending the Version says he is IE.
I could also do it via jquery, but for me this worked always less stable. Real secure is only a more robust php script, or we leave the history.js outside for all.
So please report if on my test site, you can or you can not see the browser message. Please don´t forget to mention the browser and Version.
Cheers
Dirk
Comment #25
dbeall commentedIt works just fine on your site, with FF3.5.6 and IE6.0, Mozilla SeaMonkey shows version Other.
If people have trouble or they are worried, they can delete the history.js
I tested it: The history plugin adds the fragment to the URL -and- using a bookmark of an image from galleriffic does open the photo in galleriffic. With out the plugin, the book-marked image opens in a default gallery.
I shouldn't say this, but the world needs to get Firefox or something worthy of accessing the internet..
Comment #26
designwork commentedHi dbeall,
so we can use the code at the moment.
I got a message from Simon about node_gallery_imagex.module.
So we wait until he checked the code.....
Dirk
Comment #27
marcy_sss commentedI answered this on another thread, but considering I read both of them when searching for a solution, here it is for all of you:
Changing
historyInit()tohistory.init()won't ever work becausehistoryInit()andhistoryLoad()are named functions in jQuery.history.js.I had the same problem with the history plugin, with Firefox and IE throwing the error mentioned above. It referenced this line:
Solution: Check your jQuery version! I realized my Drupal install was running version 1.2.6, though the
live()method wasn't introduced until later, most likely 1.3. I would recommend updating your jQuery to the latest... but keep an eye out for other errors that may pop up. The JQuery Update module might help in the update process....Also, the script that shipped with this module (example here) has an error. It references "advanced.html" in the history plugin, which actually refers to an example page on Google Code. A dynamic page in Drupal would never be called "advanced.html," so I just changed it to
this.href.The module example above also throws an error:
$.historyInitis not a function -- probably because the history plugin wasn't included in the source.Comment #28
dbeall commentedplease provide a patch or post changes long hand if you have this fixed
Comment #29
dbeall commentedjquery 1.3.* and jquery 1.4.* breaks lightbox2
Comment #30
marcy_sss commentedHmmm... it seems that jQuery 1.3 and 1.4 break Views and CKEditor as well. LAME! I think those are more important than a history plugin, personally, so I reverted to 1.2.6.
I haven't written a patch before, so my apologies for not providing one. Add that to the list of things I need to learn! :)
Comment #31
dbeall commentedno apologies please.. we all learn every day. Life is a huge uphill learning curve and then along came Drupal
I have written a few patches using other peoples code that was posted, but I don't know how to write any code. lol
I would rather know how to code and not know how to write a patch if I had my choice.
1.3 breaks a lot of things
http://drupal.org/search/apachesolr_search/js%201.3
1.4 same issues
http://drupal.org/search/apachesolr_search/js%201.4
Comment #32
marcy_sss commentedI just turned the history plugin off, and the gallery works fine. It doesn't break up the URLs like it did before (that's what the history plugin does), but I will gladly sacrifice that functionality for a working gallery, Views and CKEditor.
I have completely rewritten the node_gallery_display module to use four slightly different versions of Gallerific, so I won't provide a patch.... but this gallery initialization code goes in
gallery-display-images-list.tpl.phpand fixes the browser error while using jQuery 1.2.6. Be sure to change the selectors to your specific ones, and the Gallerific settings to whatever you use. I have some options turned off.If anyone knows of an alternative to the jQuery
live()method that will keep the history plugin working in version 1.2.6, let me know! History is a really nice feature... but I decided it had to go in order to keep everything else running smoothly. Too many other things to do.Comment #33
rucativava commentedEverytime I enable history, in IE I cannot browse the images clicking in the next ou previous buttons, though I can if I use the keyboard navigation. In Firefox and Safari everything goes fine.
I still haven't found a solution to this, which is a pain. Any help, appreciated.
Comment #34
designwork commentedHi All,
I have the display plugin running even on IE 8, lower Version of IE I do not support. The latest version of it gives the user even a message if a he is running on IE and the history plugin is turned of with IE.
To control the js settings of the galleries go to the controllslider.js in every folder. There you can manage the settings.
A lott of problems I saw with other people is the CSS, but this should be easy to change on the fly with firefox and firebug.
So try the new verison.
Dirk
Comment #35
jackhutton commentedi came into an issue where users in Internet Explorer IE 8 could not navigate by clicking the thumbnail images;
the 'error on page' message read:
after reading ; i went to the galleriffic view default view;
style - default style options;
Changed 'History' from 'Yes' to 'No'
flushed the cache;
and the thumbnail click navigation works..
so this would seem to be an IE compatiblity issue .. but happy to forego 'history' for functionality..
thought I'd share this solution.