Hi,

Great module! Ad and easy slider work great - seems to be a bug with the Galleriffic though...

When Galleriffic runs in IE8, clicking the thumbnails doesnt bring up the new main display image. This error is produced:

Message: Object doesn't support this property or method
Line: 350
Char: 9
Code: 0

Firefox works fine.

Thanks for the suggestions dbeall but unfortunately unsuccessful (presumably you meant make the changes to the gallery-display-images-list.tpl file in the theme folder?)

Cheers, Joe

Comments

designwork’s picture

Assigned: Unassigned » designwork

Hi Joe,

I do not have IE8 on any computer (MAC user). I will have to get a Comptuer with IE8. Can you check if this is only IE8 or also IE7 and 6.

Cheers

Dirk

dbeall’s picture

all I have is IE6 and it has same error. Microsoft seems to always be a problem child...
I looked at the latest .js from galleriffic and historyinit is being used.
A google search turned up the possible problem. historyinit has to be history.init
But I don't know any programming.. that's what they were saying.

joecanti’s picture

Hi dirk,

Thanks for the quick reply..Testing results:

IE6:
Ad Slider is fine (only minor issue is there is no white background behind caption on adslider)

Easy Slider works fine

Galleriffic - clicking thumbs does not do anything - line: 352 char: 9 Object doesnt support this property or method.

Tested this on 2 different sites.

I cannot get IE7 to load up at the moment - will keep trying and let you know.

Not sure what the set up is on a mac but we cannot run 2 versions of a browser eg IE6 & IE7 on the same machine on a PC so I tested it at www.spoon.net/browsers - i think this is pc only as it installs a plug in - there may be a mac version out there somewhere.

Cheers, Joe

dbeall’s picture

This is weird.. Goto the demo site for galleriffic with IE and it works
http://www.twospy.com/galleriffic/example-3.html

joecanti’s picture

ok

Tested in IE7 now and the same problem comes up...

Found this great little app: http://www.my-debugbar.com/wiki/IETester/HomePage

Saves me lots of time on browser sandboxes etc - again, not sure about a MAC version - think its only possible with VMWare.

cheers, Joe

designwork’s picture

StatusFileSize
new5.91 KB

Hi Joe,

try this one (fast fix). rename the file and copy it to your js/full folder. Make a copy of the old one first.

Dirk

joecanti’s picture

thanks Dirk,

There is a syntax error on line 21 but ignoring this it now works! when clicking thumbnails in IE7 and IE8 the image changes...

In IE6 the thumbs do not show up, but clicking the space where they should be makes the image change also.

cheers, joe

designwork’s picture

Hi Joe,

what do you mean with syntax error? Can you post the error message! As I do not have IE8 I can not reproduce it.

Dirk

joecanti’s picture

Sorry - I should have mentioned - Dreamweaver popped up with the Syntax error. The error disappears when the . is removed from hisory.innit on line 21

The IE errors are the same as before...

cheers, joe

designwork’s picture

Dear Joe,

before you moved the "dreamweaver syntax" error it worked on IE8 right?
If yes let the dot where it was.
If not we start again.

dbeall’s picture

well, I tried the file and it broke the gallery in FF and IE6,
shows all the thumbnail images with the captions, and when clicked they opened full image.

dbeall’s picture

there is another call to that function $.historyInit in jquery.galleriffic.js @@ 868
there may be some others..
EDIT: I tried renaming the other calls to the function.. no luck

joecanti’s picture

hi Designwork,

sorry for the slight delay - here is what i did:

I used dreamweaver to create the js file from your text file (just renamed it) but noticed that dreamweaver picked up on a syntax error. I ignored this error, saved and copied the .js to the right place - when opening up the gallery it worked - the thumbs were bringing up the main images - but the previous error was still coming up plus a scripting error, which I imagine was refferring to the syntax error found by dreamweaver.

Here is what IE says as the errors:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Win64; x64; Trident/4.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Sat, 23 Jan 2010 20:21:52 UTC

Message: Expected ':'
Line: 21
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/sites/all/modules/node_gallery/contr...

Message: Expected identifier
Line: 47
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/?q=node/31

Message: Object doesn't support this property or method
Line: 281
Char: 9
Code: 0
URI: http://www.avocet-designs.co.uk/isy/?q=node/31

Unfortunately IE doesn't give much away - and the problem doesn't seem to exist with any other browsers. Its annoying that IE is at the source of most cross browser issues - you are lucky to be on a MAC!!

cheers, joe

dbeall’s picture

I have been playing with this..
Try removing the jquery.history.js file completely and it works for me

It's something to do with the on click event.?
maybe here.?
$("a[rel='history']").live('click', function()

dbeall’s picture

I will pull it out of my demo real quick

dbeall’s picture

dbeall’s picture

jQuery.history plugin integration to support bookmark-friendly URLs per-image rather than one URL using the gallery name for all images

joecanti’s picture

hi dave,

Works on IE6, IE7 and IE8..

Still has the original error as below...but only 1 error and not 3

Does the file you removed just deal with the hstory, or os there more to it than that?

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Win64; x64; Trident/4.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Sat, 23 Jan 2010 22:16:38 UTC

Message: Object doesn't support this property or method
Line: 348
Char: 9
Code: 0
URI: http://www.davebeall.com/node-gallery4/galleriffic_photo_gallery

(this error is just the one that appears down the bottom left of IE as the yellow warning triangle but doesnt seem to affect operation whatsoever!)

cheers, joe

dbeall’s picture

The history thing is just to generate a unique URL in the address bar for each image, rather than the same URL for all images in the gallery. But the xmlsitemap still shows all the individual images.

I didn't notice the error, it just was working.
there were a lot of people on the web hunting for the answer to this error..
some of it was click event, some was a naming issue, and the list goes on and on.. Much of it was over my little brain.. ug..

designwork’s picture

Hi dbeall,

nice chatch, I will make a browser ceck and if we have an IE browser we remove the history.js.

Thanks

Dirk

dbeall’s picture

there is one other thing, but I'm not sure.
If you book mark the image when viewing the galleriffic gallery and follow the bookmark back to the site, ?? I think it will open galleriffic to view the image..??
I would have to test that part to see what it does.

If the image URL is followed from the xmlsitemap URL, it will open the image in a default node_gallery gallery.
But I don't see the xmlsitemap creating the fragmented URL like the history plugin does...
it is just normal Drupal, URL alias path.

I think I have to look closer at this...

designwork’s picture

StatusFileSize
new74.95 KB

Hi All,

here comes a new version of the module. It will check the browser and insert different js for each browser, if necessary.
But it will also display a message on galleriffic galleries to change the browser and get a descent one.

I can remove this message. But IE sucks!!!

Cheers

Dirk

dbeall’s picture

I hate to add this,, but......
function node_gallery_display_get_browser($useragent){
--is not working in my test.--
lots of discussion about this function on the net..

Ran across this page on Drupal
http://drupal.org/node/65903

designwork’s picture

Hi dbeall,

Hm do you think this is a caching problem. The function on node 65903 is not the same as mine. But we can test it more. I will do a simple test on my test page. http://photographer.freelens.ws

There anybody going to http://photographer.freelens.ws/galleries and then choose a gallery will see a message with his browser and the version of it like:


Your Browser is Firefox Version: 3.0.3
Your Browser is Safari Version: 532.5
Your Browser is Safari Version: 531.21.10
Your Browser is other Version: 0

One Problem is for example, that Chrome pretends to be Safari and that Opera, depending the Version says he is IE.
I could also do it via jquery, but for me this worked always less stable. Real secure is only a more robust php script, or we leave the history.js outside for all.

So please report if on my test site, you can or you can not see the browser message. Please don´t forget to mention the browser and Version.

Cheers

Dirk

dbeall’s picture

It works just fine on your site, with FF3.5.6 and IE6.0, Mozilla SeaMonkey shows version Other.
If people have trouble or they are worried, they can delete the history.js

I tested it: The history plugin adds the fragment to the URL -and- using a bookmark of an image from galleriffic does open the photo in galleriffic. With out the plugin, the book-marked image opens in a default gallery.

I shouldn't say this, but the world needs to get Firefox or something worthy of accessing the internet..

designwork’s picture

Hi dbeall,

so we can use the code at the moment.

I got a message from Simon about node_gallery_imagex.module.

sdrycroft - January 25, 2010 - 11:09
new

Hi Dirk. This all sounds great. Given that the code I've released is GPL (as is Postlet), I actually can't say no to your request. I personally would prefer a single combined module (i.e. join forces) for this. I'll have a look at your code ASAP (a little bogged down with work at the mo' I'm afraid though), and will get back to you.

Simon

So we wait until he checked the code.....

Dirk

marcy_sss’s picture

I answered this on another thread, but considering I read both of them when searching for a solution, here it is for all of you:

Changing historyInit() to history.init() won't ever work because historyInit() and historyLoad() are named functions in jQuery.history.js.

I had the same problem with the history plugin, with Firefox and IE throwing the error mentioned above. It referenced this line:

$("a[rel='history']").live('click', function() {
    // moves to a new page.
})

Solution: Check your jQuery version! I realized my Drupal install was running version 1.2.6, though the live() method wasn't introduced until later, most likely 1.3. I would recommend updating your jQuery to the latest... but keep an eye out for other errors that may pop up. The JQuery Update module might help in the update process....

Also, the script that shipped with this module (example here) has an error. It references "advanced.html" in the history plugin, which actually refers to an example page on Google Code. A dynamic page in Drupal would never be called "advanced.html," so I just changed it to this.href.

The module example above also throws an error: $.historyInit is not a function -- probably because the history plugin wasn't included in the source.

dbeall’s picture

please provide a patch or post changes long hand if you have this fixed

dbeall’s picture

jquery 1.3.* and jquery 1.4.* breaks lightbox2

marcy_sss’s picture

Hmmm... it seems that jQuery 1.3 and 1.4 break Views and CKEditor as well. LAME! I think those are more important than a history plugin, personally, so I reverted to 1.2.6.

I haven't written a patch before, so my apologies for not providing one. Add that to the list of things I need to learn! :)

dbeall’s picture

no apologies please.. we all learn every day. Life is a huge uphill learning curve and then along came Drupal
I have written a few patches using other peoples code that was posted, but I don't know how to write any code. lol
I would rather know how to code and not know how to write a patch if I had my choice.

1.3 breaks a lot of things
http://drupal.org/search/apachesolr_search/js%201.3

1.4 same issues
http://drupal.org/search/apachesolr_search/js%201.4

marcy_sss’s picture

I just turned the history plugin off, and the gallery works fine. It doesn't break up the URLs like it did before (that's what the history plugin does), but I will gladly sacrifice that functionality for a working gallery, Views and CKEditor.

I have completely rewritten the node_gallery_display module to use four slightly different versions of Gallerific, so I won't provide a patch.... but this gallery initialization code goes in gallery-display-images-list.tpl.php and fixes the browser error while using jQuery 1.2.6. Be sure to change the selectors to your specific ones, and the Gallerific settings to whatever you use. I have some options turned off.

<script type="text/javascript">
<!--
jQuery(document).ready(function($) {
        // We only want these styles applied when javascript is enabled
        $('div.slider-content').css('display', 'block');

        // Initially set opacity on thumbs and add
        // additional styling for hover effect on thumbs
        var onMouseOutOpacity = 0.5;
        $('#thumbs ul.thumbs li, div.navigation a.pageLink').opacityrollover({
          mouseOutOpacity:   onMouseOutOpacity,
          mouseOverOpacity:  1.0,
          fadeSpeed:         'fast',
          exemptionSelector: '.selected'
        });
        
        // Initialize Advanced Galleriffic Gallery
        var gallery = $('#thumbs').galleriffic({
          delay:                     1000,
          numThumbs:                 10,
          preloadAhead:              10,
          enableTopPager:            false,
          enableBottomPager:         false,
          imageContainerSel:         '#slideshow',
          controlsContainerSel:      '#controls',
          captionContainerSel:       '#caption',
          loadingContainerSel:       '#loading',
          renderSSControls:          false,
          renderNavControls:         false,
          playLinkText:              'Play Slideshow',
          pauseLinkText:             'Pause Slideshow',
          prevLinkText:              '&lsaquo; Previous Photo',
          nextLinkText:              'Next Photo &rsaquo;',
          nextPageLinkText:          'Next &rsaquo;',
          prevPageLinkText:          '&lsaquo; Prev',
          enableHistory:             false,
          autoStart:                 false,
          syncTransitions:           true,
          defaultTransitionDuration: 500,
          onSlideChange:             function(prevIndex, nextIndex) {
            // 'this' refers to the gallery, which is an extension of $('#thumbs')
            this.find('ul.thumbs').children()
              .eq(prevIndex).fadeTo('fast', onMouseOutOpacity).end()
              .eq(nextIndex).fadeTo('fast', 1.0);

            // Update the photo index display
            this.$captionContainer.find('div.photo-index')
              .html((nextIndex+1) +' of '+ this.data.length);
          },
          onPageTransitionOut:       function(callback) {
            this.fadeTo('fast', 0.0, callback);
          },
          onPageTransitionIn:        function() {
            var prevPageLink = this.find('a.prev').css('visibility', 'hidden');
            var nextPageLink = this.find('a.next').css('visibility', 'hidden');
            
            // Show appropriate next / prev page links
            if (this.displayedPage > 0)
              prevPageLink.css('visibility', 'visible');

            var lastPage = this.getNumPages() - 1;
            if (this.displayedPage < lastPage)
              nextPageLink.css('visibility', 'visible');

            this.fadeTo('fast', 1.0);
          }
        });

        /**************** Event handlers for custom next / prev page links **********************/

        gallery.find('a.prev').click(function(e) {
          gallery.previousPage();
          e.preventDefault();
        });

        gallery.find('a.next').click(function(e) {
          gallery.nextPage();
          e.preventDefault();
        });
 });
//-->
</script>

If anyone knows of an alternative to the jQuery live() method that will keep the history plugin working in version 1.2.6, let me know! History is a really nice feature... but I decided it had to go in order to keep everything else running smoothly. Too many other things to do.

rucativava’s picture

Everytime I enable history, in IE I cannot browse the images clicking in the next ou previous buttons, though I can if I use the keyboard navigation. In Firefox and Safari everything goes fine.
I still haven't found a solution to this, which is a pain. Any help, appreciated.

designwork’s picture

StatusFileSize
new93.89 KB

Hi All,

I have the display plugin running even on IE 8, lower Version of IE I do not support. The latest version of it gives the user even a message if a he is running on IE and the history plugin is turned of with IE.

To control the js settings of the galleries go to the controllslider.js in every folder. There you can manage the settings.
A lott of problems I saw with other people is the CSS, but this should be easy to change on the fly with firefox and firebug.

So try the new verison.

Dirk

jackhutton’s picture

i came into an issue where users in Internet Explorer IE 8 could not navigate by clicking the thumbnail images;
the 'error on page' message read:

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; Comcast Install 1.0; .NET CLR 2.0.50727; .NET CLR 1.1.4322; OfficeLiveConnector.1.3; OfficeLivePatch.0.0; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Tue, 29 Mar 2011 21:14:41 UTC

Message: Object doesn't support this property or method
Line: 99
Char: 7
Code: 0
URI: http://www.example-site.com/sites/all/modules/views_galleriffic/js/views...

after reading ; i went to the galleriffic view default view;
style - default style options;
Changed 'History' from 'Yes' to 'No'
flushed the cache;
and the thumbnail click navigation works..
so this would seem to be an IE compatiblity issue .. but happy to forego 'history' for functionality..
thought I'd share this solution.