I looked into it, and the reason is that the parameter is being set wrong. It should be
<fb:profile-pic facebook-logo="true"></fb:profile-pic>
but it's being output as
<fb:profile-pic facebook-logo="1"></fb:profile-pic>
The problem is that in theme_fbconnect_user_picture_override() the $logo parameter is being passed as a PHP boolean value instead of the string "true". I just placed if ($logo) $logo = 'true'; into the top of theme_fbconnect_user_picture_override() like so:

<?php
function theme_fbconnect_user_picture_override($fbuid = '', $account = '', $user_url = '', $size = 'square', $logo = TRUE) {
  // new code fix is here
  if ($logo) $logo = 'true';
  $output = <<<PIC
      <div class="picture">
        <a href="$user_url">
         <fb:profile-pic uid="$fbuid" linked="false" size="$size" facebook-logo="$logo"></fb:profile-pic>
        </a>
      </div>
PIC;
  return $output;
}
?>

I don't know if there is a better way to do it, but this fixes it.

Comments

Aquilasfx’s picture

Aquilasfx commented

can you share your facebook.module .... i can't show any avatar also with your modified version: "adding s" to user_profiles....

thaddeusmt’s picture

thaddeusmt commented

I'll post a patch eventually, but alas I don't have time right now. Don't have patch generating stuff set up on this box. It's easy to make the change in the code in the mean time. Just be sure to refresh the Drupal cache, as always. :)

vectoroc’s picture

vectoroc commented
Status: Active » Fixed

Fixed in git. Will be released soon

cerup’s picture

cerup commented

I downloaded the latest git version 15 minutes ago. This is not fixed.

cerup’s picture

cerup commented
Status: Fixed » Active

changing status

vectoroc’s picture

vectoroc commented

see http://github.com/vectoroc/fbconnect/blob/master/fbconnect.pages.inc
and http://skitch.com/vectoroc/n5bpm/admin-fbconnect.loc
I'm pretty sure that it's fixed

vectoroc’s picture

vectoroc commented
Status: Active » Fixed
cerup’s picture

cerup commented
Status: Fixed » Needs review

The problem is that now you can't uncheck the option. If you uncheck it, it still shows the facebook icon - and also when you reload the setting page it puts the checkbox back to true. So it sounds like the opposite problem as before.

vectoroc’s picture

vectoroc commented
Status: Needs review » Fixed

Thanks, now I see where is problem. Fixed, see github

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.