There are several instances of losing breadcrumbs in core. One that just stuck out to me was on the URL alias edit form. The local 'action' Add URL alias has nice breadcrumbs, but the 'Edit' callback does not. This is a *major* WTF for our users.

CommentFileSizeAuthor
#6 692868_breadcrumbs.patch719 bytesmcarbone
screenshot_040.png52.72 KBdave reid
screenshot_039.png62.08 KBdave reid
screenshot_038.png41.31 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Also note how the tabs disappeared on the second/callback screenshot.

mcarbone’s picture

mcarbone commented

Huh, I'm not getting the tabs either way on a fresh install, but I can confirm the breadcrumb problem. Also, I don't see in the menu code where the "Patterns" and "Settings" tabs come from -- what path do they go to for you?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's an experimental version of pathauto for D7 I'm working on. I'll try and find an example of just core code that this happens on with tabs disappearing.

mcarbone’s picture

mcarbone commented

The tab thing I think you might want to put in a separate issue anyway. The breadcrumb problem I'm pretty sure is unrelated, and it is very widespread (when editing vocabs, terms, menu items, etc.).

It's looking like it's happening because when menu_set_active_trail queries the menu_links table, it's searching that table for the menu being used using the full qualified path, e.g., "admin/config/search/path/edit/1", which of course is not going to return a result from that table. This is probably an issue for a menu guru, but I'm still digging for the fun of it.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Closed (duplicate)

Gah, found the original issue at #576290: Breadcrumbs don't work for dynamic paths & local tasks

mcarbone’s picture

mcarbone commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new 692868_breadcrumbs.patch719 bytes

This simple fix seems to resolve the breadcrumb problem and a manual test looks good. Let's see how the testing bot does.

mcarbone’s picture

mcarbone commented
Status: Needs review » Closed (duplicate)

Ah. Heh.