When using imagecache for thumbnails and the field is empty, a broken image shows up

subscribing

This is happening on our site, too. Unfortunately, ours is live already. Anyone have any ideas?

If it helps, the image url it displays is the imagecache preset directory with no file specified.

Please help! Thanks!

-Jesse

I fixed the issue with a theme function to make sure imagecache had a path before building an img tag:

function THEMENAME_imagecache($presetname, $path, $alt = '', $title = '', $attributes = NULL, $getsize = TRUE) {
   if (is_null($path)) {
    return '';
  }
  // Check is_null() so people can intentionally pass an empty array of
  // to override the defaults completely.
  if (is_null($attributes)) {
    $attributes = array('class' => 'imagecache imagecache-'. $presetname);
  }
  if ($getsize && ($image = image_get_info(imagecache_create_path($presetname, $path)))) {
    $attributes['width'] = $image['width'];
    $attributes['height'] = $image['height'];
  }

  $attributes = drupal_attributes($attributes);
  $imagecache_url = imagecache_create_url($presetname, $path);
  return '<img src="'. $imagecache_url .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. $attributes .' />';
}

I'm not sure if this is something emfield has any control over, looks to me like an oversight on imagecache's part.

I just found another solution in the imagecache issues- might be useful. Looks similar.

http://drupal.org/node/745344

Best,

-Jesse

Oh- wait. they're both dafeder. Good job!

Thanks- The fix got rid of the imagecache missing thumbnail beautifully!

The emvideo play button replacement is still hanging around, though.

Any thoughts? Thanks!

Can you post an example URL?

I've attached some screen captures, and http://www.dctvny.org/documentaries/hunger-suburbs is a good example of a broken one. Any thoughts?

Thanks,

-Jesse

Just wanted to check in on this- any ideas?

I'm closing this- the correct way to remove the player image is to uncheck "Thumbnail play button overlay" under thumbnails at admin/content/emfield

@ #11, unchecking "Thumbnail play button overlay" at the admin/content/emfield isn't really a solution. You shouldn't have to sacrifice functionality in order to avoid a bug.

Also, the field is still being generated. Look at this:

http://www.adambadlotto.com/work/branding/peace-studies-identity

The label 'Videos' is still there, even though the field is empty.

subscribing

make sure you also set in the Row/Field style to hide empty fields - thanks the fix worked for me!

Could you give me an example of what the code should look like? I'm not familiar with php. Thanks!

Im still having this issue, views seems to be including an empty row for empty embed video fields. I have never checked the "Thumbnail play button overlay" and im currently not using imagecache for the thumbnail. I also have all the options in views checked to avoid outputting empty fields.

Why is Embedded Media Field causing empty rows like this? I can't show the empty text for my view when no video is added as it is never empty. Anyone else having this issue?

Still not sure why markup is being created for the empty field but found a quick fix for hiding the empty row. http://drupal.org/node/672632#comment-2857946

The 'Play' png for the video is visible when viewing any node that has the emvideo field, even if the video field is blank.

This is a quick fix:

- Find the function theme_emvideo_modal_generic in emvideo.theme.inc.
- Paste the function into template.php in you themes directory.
- change the theme_ part of the function name to match your theme name
- change the last line of the function from:

 return $output; 

to

if ($options['node']->{$options ['field']['field_name']}[0]['value']) {
 return $output;
}else {
 return "";
}

Not sure why this function is even being called.

Note that if you decide to go back to a different option to display the videos (ie not using lightbox) you may need to remove the above code.

Many thanks for that fix #19! For those looking, emvideo.theme.inc should be in /sites/all/modules/emfield/contrib/emvideo/

Still have this problem.
The thumbnail is not showing up when using imagecache.

I've spent some time debugging this and I'm pretty sure the problem is in the _emthumb_imagecache_formatter_default() theme function. This output of this functions is NULL, because it provide an external link to theme_image and theme_imagecache.