The views data hook for data_taxonomy does some aggresive setting of relationships for many data tables that may result in overwrites upon array_merging as views assembles the cache. Test and possibly move to hook_views_data_alter() or re-architect.

CommentFileSizeAuthor
#5 693056_5.patch1.57 KBDavid Goode
#4 693056_4.patch1.55 KBDavid Goode
#3 693056_3.patch1.54 KBDavid Goode
#2 693056_2.patch1.51 KBDavid Goode
#1 data_taxonomy_renamerelationships.patch1.51 KBDavid Goode

Comments

David Goode’s picture

David Goode commented
Status: Active » Needs review
StatusFileSize
new data_taxonomy_renamerelationships.patch1.51 KB

Now it creates a relationship prepended with its own module/table name; shouldn't have any conflict issues anymore. All views implementing it must be recreated/will be broken.

David Goode’s picture

David Goode commented
StatusFileSize
new 693056_2.patch1.51 KB

Named patch according to standards, same content as before.

David Goode’s picture

David Goode commented
StatusFileSize
new 693056_3.patch1.54 KB

Sorry, but added file paths to work better with automatic make files.

David Goode’s picture

David Goode commented
StatusFileSize
new 693056_4.patch1.55 KB

Another path rename for drush make purposes :-(

David Goode’s picture

David Goode commented
StatusFileSize
new 693056_5.patch1.57 KB

Again, sorry!

alex_b’s picture

alex_b commented
Assigned: alex_b » Unassigned
Status: Needs review » Reviewed & tested by the community

This is RTBC - is there an open issue for the new "@TODO this really doesn't belong here" ? Are you planning to fix that?

alex_b’s picture

alex_b commented
Issue tags: +6.x-1.0-alpha13

To be released with 6.x-1.0-alpha13.

alex_b’s picture

alex_b commented
Title: Check data_taxonomy views data hook to see if it deletes other data views entries » data_taxonomy - don't override existing relationships
Status: Reviewed & tested by the community » Fixed

Committed, thank you.

http://drupal.org/cvs?commit=417662

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.0-alpha13

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +6.x-1.0-alpha13

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.