After translation from English to another language, the replace function didn't work anymore.
To fix that bug, line 413 of the scanner.module file has to be changed from

if ($form_state['values']['op'] == 'Replace') {

to

if ($form_state['values']['op'] == t('Replace')) {

Greetings,
DRé

CommentFileSizeAuthor
#7 20101119-tfix.patch.txt568 bytesasb

Comments

pmunch’s picture

Thanks Dré !
@maintainers : please consider a new module release with this bug fixed as it makes this very useful module... useless for non-english sites and users... Thanks !

dokuf’s picture

Subscribe!

asb’s picture

asb’s picture

Status: Active » Reviewed & tested by the community

@quasidre: Thanks for this incredibly useful fix. I can confirm the issue, and confirm that the fix is working as advertised on a localized German site.

Do we need to roll this into a proper patch to get it into a release?

Greetings, -asb

altundal’s picture

subscribing.

This is a localization issue which "should" be fixed also in new version because module is becoming totally useless when switches to any other language.

Due to the development way of the module, quasidre's fix is ok!

kscheirer’s picture

@quasidre and asb:

Yes, please provide a patch if you can! That makes things much easier on the maintainers, and gives the issue a better chance to get resolved. This particular change is fairly trivial, but it's good practice.

Check out the Creating Patches handbook.

asb’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new568 bytes

If you think so...

asb’s picture

Priority: Critical » Major

Issue still exists, but doesn't affect other modules or Drupal core, so adjusting priority.

hass’s picture

Issue summary: View changes
Status: Needs review » Closed (duplicate)
Parent issue: » #1544198: Replace button not working on other than English locale