Good day! I am willing to submit a patch that would add a second option for the floating collapsible feedback icon.

Against which branch should that go? 6.x-2.x.-dev ?

Marking it critical cause I would like a fast answer. And since it is not a bug thus I do not harm the module's reputation.

Comments

jcruz’s picture

Yes. You want to patch against dev. See http://drupal.org/patch/submit for more info on submitting patches.

sun’s picture

Title: Lets add a UI alternative - a floating nice Icon ala Get Satisfaction » Alternative UIs/themes
Priority: Critical » Normal
cerup’s picture

rsvelko , have you worked on this at all?

antgiant’s picture

StatusFileSize
new585 bytes

The attached patch does two things.
First it provides rounded corners via CSS, to all browsers that currently implement that option.
Second it provides some whitespace to make our designer happy. :-)

However, it currently applies to the main (only) theme.

Code moved here from #478802: Rounded Corners and Some Spacing as requested by sun

idcm’s picture

Hi AntGiant

However, it currently applies to the main (only) theme.

Can you please clarify this statement? I ask because maybe I am misunderstanding. The patch shows feedback.css being changed. I inserted this patch as suggested and dont see a difference. Do you have a screenshot of what I should expect to see?

c

antgiant’s picture

StatusFileSize
new632 bytes
new5.46 KB
new5.17 KB

Attached are two screenshots showing the difference. The original patch may have needed some slight tweaking. I have attached a tweaked version. Hope that helps.

P.S. Rounded corners don't work in IE (yet).

idcm’s picture

thanks antgiant, we will explore this more

jody lynn’s picture

Status: Active » Closed (won't fix)

I don't think this belongs as a patch, it's simply a site-specific theming approach.

sun’s picture

Status: Closed (won't fix) » Postponed

Let's leave this as postponed for now. Providing a clear infrastructure and code/API path for alternate UIs (including alternative behaviors) is one of the key challenges for Feedback module.

To state some kind of direction upfront, I'm envisioning an integration with Skinr.

R-H’s picture

Following

jody lynn’s picture

This is on hold right now waiting stability of skinr.

jody lynn’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
rkarajgi’s picture

I used the feedback module - it is great. I was struggling with having the feedback button show up on the right (or left) as a button with vertical letters as is done by 3rd party feedback providers.

I managed to get it done just using css. I am posting the css I used here - hopefully it may help someone trying to do same thing:

Add the following css to your local.css of your theme.

#block-feedback-form {top:250px; right:40px; left:inherit;bottom:inherit;height:auto;}
#block-feedback-form.block .inner {margin:0px; padding:0px;}
#block-feedback-form .feedback-link {
        color:white;
        background:red;
        border:0px solid red;
        writing-mode:tb-rl;
        -webkit-transform:rotate(90deg);
        -moz-transform:rotate(90deg);
        -o-transform: rotate(90deg);
        white-space:nowrap;
        display:block;
        font-family: ‘Trebuchet MS’, Helvetica, sans-serif;
        font-size:20px;
        font-weight:normal;
        text-shadow: 0px 0px 1px #333;
        padding:5px;
        padding-right:15px;
        position:fixed;
        bottom:inherit;
        right: -50px;
}

#block-feedback-form form { padding:20px; max-width:none;}

If you want the tab on the left, change first line to have "left:40px; right:inherit" instead and also change the "right:-50px" to "left:-50px".

Renee S’s picture

Thanks __rajeev, exactly what I was looking for. It doesn't work in IE, unfortunately, so I added this in my ie_fixes.css file in addition to your CSS. The overrides are embarrassing, but anyway, if it helps somebody :)

#block-feedback-form {
	background-position: 2px 50% !important;
	position: fixed !important;
	top: 45% !important;
	display: block !important;
	margin: -45px 0 0 0 !important;
	padding: 0 !important;
	z-index: 100001 !important;
	background-position: 2px 50% !important;
	background-repeat: no-repeat !important;
	right: auto !important;
	left: auto !important;
}
#block-feedback-form .feedback-link {
	padding: 10px 10px 10px 15px;
}
#block-feedback-form h2 span {
	background-color: black !important;
	border: outset 2px black !important;
	border-left: none !important;
	width: 65px !important;
	height: 110px !important;
}

Initial code stolen from the UserVoice feedback button code.

TribalMan’s picture

Helped me heaps

jody lynn’s picture

Status: Postponed » Needs work
StatusFileSize
new9.29 KB

I'm working on making the appearance of the form pluggable and including a left tab option.

I have the tab working but want to switch the form to a modal in this case as was done in #1291558: A nicer default UI (ala getsatisfaction.com).

jody lynn’s picture

Assigned: rsvelko » jody lynn
muka’s picture

The patch in #16 doesn't apply anymore.
This look promising, any updates?

dbassendine’s picture

Issue summary: View changes
StatusFileSize
new3.22 KB

I've adapted the styles provided in #13 and #14 for a right hand tab display in black (and somewhat smaller). Tested across IE7-11, Firefox 18-33, Chrome 38, Safari 5-8. Not perfect but provides a base for more modern styling.

This doesn't build on the pluggable approach in #16, though it would be great to revive that and provide these styles as an option there.

jody lynn’s picture

StatusFileSize
new7.69 KB

This is a reroll of #16

jody lynn’s picture

StatusFileSize
new14.01 KB

Better styling for left tab display.

jody lynn’s picture

Status: Needs work » Needs review
dbassendine’s picture

StatusFileSize
new3.64 KB

Update to the alternative styling from #14, fixing: firefox positioning, flash of feedback form on page refresh, move up slightly, hide previously sent messages (they push the form off screen in this layout)

dbassendine’s picture

StatusFileSize
new3.62 KB

Update to #23 that allows the form to collapse properly after submit, and fixes some cross-browser issues.

mparker17’s picture

Status: Needs review » Closed (outdated)

The floating icon no longer exists in the 3.x branch.

The Drupal 7 version of Feedback is no longer available, and no longer maintained. (If you'd like to maintain the Drupal 7 version, please post an issue in the queue)

So I'm going to close this issue as outdated.

Thanks in advance for your patience and understanding as I try to clean up this project's issue queue!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.