Closed (fixed)
Project:
Tweet
Version:
6.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2010 at 21:39 UTC
Updated:
15 Feb 2010 at 03:30 UTC
It would be cool if it would be possible to post links to identi.ca for example too.
This patch creates a hook so that other modules can define "tweet services".
The code is not tested well, as well as it misses the identi.ca extra module.
| Comment | File | Size | Author |
|---|---|---|---|
| tweet-identica.patch | 4.95 KB | dawehner |
Comments
Comment #1
icecreamyou commentedThanks for the patch, I'll review it as soon as I get a chance.
Comment #2
dawehnerPatch works fine for me, so update status.
Comment #3
icecreamyou commentedGenerally, the patch looks good, and I appreciate the work you've done on this. In terms of the actual code I just have one minor gripe:
That needs to have $services passed in as a parameter so modules that implement this have something to alter.
I think, though, that your approach requires a little too much work on the part of modules implementing the hook. I want the hook to return only keywords, not code -- that is, I don't want the client module to have to figure out where the icons are, or that theme('image') exists, etc. I'd like to see the "Text of link" function change to use a
%servicetoken have have the client hook just provide the name of the service instead of the full link text, for example.I will think about this a little more and try to massage your patch tonight.
Comment #4
icecreamyou commentedI created a new 4.x branch for these changes because they require changing the API. I would appreciate if you could try it out and see if it works for you.
Comment #5
icecreamyou commentedI'm going to go ahead and mark this fixed. If any problems are found with the 4.x branch, or if anyone has a new service to contribute, please open a new issue.