The parameters for the gmap_set_location() have changed and therefore this patch is necessary. (Note this patch also includes the very minor change to fix the bug reported in http://drupal.org/node/61847

Thanks
James (Webgeer)

CommentFileSizeAuthor
gmapChange-location.inc.patch1.14 KBwebgeer

Comments

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Needs work

what shoud that mean?

array('latitude'=>'latitude','longitude'=>'longitude')

I applied the patch and get the following error:

Fatal error: Only variables can be passed by reference in /home/www/wa0310/html/test/modules/location/location.inc on line 440
webgeer’s picture

webgeer commented
Status: Needs work » Needs review

It sounds like you do not have the latest cvs version of gmap.module. This patch will only work if the cvs version of gmap.module is installed. Then it will work fine. (I will make the cvs version of gmap.module the 4.7 version when this patch is accepted).

Tobias Maier’s picture

Tobias Maier commented

I do more then twice a day a cvs -q update -dP on my local contributions-HEAD and contributions-DRUPAL-4-7 copy
and after this sitecopy -qu the_specific_site to upload the the changed files...
so I wouldnt say that I use(d) an old version...

but when I'm back home i will try it again...

webgeer’s picture

webgeer commented

I had updated the cvs version of of gmap.module within minutes of submitting this patch. It is one of the problems of having very interconnected modules like this is that I didn't want to upload the change to gmap without having the patch to location.module available.

Hopefully it does work for you now with the latest version of the gmap.module.

billk2’s picture

billk2 commented

Any news on this patch making it to 4.7.0?

I've got a problem with gmap that's apparently dependent on this to fix it.

karens’s picture

karens commented

The fixes here and in gmap work for me.

bahwi’s picture

bahwi commented

Any idea when this will go in? I need to be able to set lat/long off the google map, geocoding doesn't give lat/long for most of the addresses that go into my system.

bahwi’s picture

bahwi commented

I got the patch to work, works great, but now the Gmap View doesn't work(although it works for User and Node list, not a custom view that only filters by node type).

webgeer’s picture

webgeer commented

Are you sure it was this patch that affected view?

All this patch does is change the call to gmap that inserts a map above the lat/long fields in the location entry form. I don't see how this could effect views in any way.

geodaniel’s picture

geodaniel commented
Status: Needs review » Reviewed & tested by the community

I've tried this patch on the current 4.7 version of the modules and it now allows me to add a location to the node using the Google Map. It'd be great if this could be committed to location.module.

walkah’s picture

walkah commented

yes, please commit.

ankur’s picture

ankur commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, DRUPAL-4-7. Thanks for the patch and comments.

I'm a bit more free to review other patches. If there's a backlog of issues you guys are interested in, please bump them on the queue.

-Ankur

geodaniel’s picture

geodaniel commented

Thanks Ankur

gisaalter’s picture

gisaalter commented
Category: task » support

Can someone send me a correct location.inc file ? I tried to apply the patch, yet I still get the same error message...Thanks

gisaalter@gmail.com

Tobias Maier’s picture

Tobias Maier commented

you dont need to apply this patch.
you just need to download the current version at our download page

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)