Inherited a project made by someone else, so had some need for some fairly random formatters.

  • Textfield that links to it's text in a seperate page (yes, strange, but they requested it!
  • Single textfield formattered as un/ordered lists based on line breaks.

Could make them as own project on d.o or (leave em to rot), but might as well inquire here first; interested?

There're both here http://github.com/hefox/formatters, textfieldlink being the former and textfieldlist the later.

Cheers

CommentFileSizeAuthor
#4 695270_textformatters_singlelist.patch2.53 KBhefox
#2 695270_textformatters_singlelist.patch1.87 KBhefox

Comments

Crell’s picture

Crell commented

The single-field-as-list formatter sounds interesting! Can you make a patch for those?

hefox’s picture

hefox commented
Status: Active » Needs review
StatusFileSize
new 695270_textformatters_singlelist.patch1.87 KB

Here's the patch for the single list formatters, with some slight changes.

Originally had a check if ($items > 1), do the theme lists, otherwise just return regularly, remove that, but not sure if I should have or not.

Never patched using cvs before, assumign cvs diff . > patchfile will work

Crell’s picture

Crell commented
Status: Needs review » Needs work

Eh, not quite. If you're patching from CVS, you want to use:

cvs diff -Nup > patchfile.patch

(CVS's default patch format is useless.)

hefox’s picture

hefox commented
Status: Needs work » Needs review
StatusFileSize
new 695270_textformatters_singlelist.patch2.53 KB

wow, I most have been very very out of it earlier cause I swear I looked at the patch after I was done, and I do know what patches look like /embarrassed O.O

becw’s picture

becw commented
Status: Needs review » Postponed

The "single textfield formattered as un/ordered lists based on line breaks" feature happened to be in the D7 port patch that I committed today! I didn't even notice it wasn't in the D6 version, but I'm glad that it had precedent!

My one comment would be that we should make sure that input formats are applied to the text after it's broken up and before it gets output--that was an issue with the first round of the D7 implementation.

Personally, I'm not interested in adding new features to the D6 version at this point. I'm gonna mark this as postponed in case someone else takes interest.

becw’s picture

becw commented
Version: 6.x-1.0 » 6.x-1.x-dev

Also, moved to dev.

damiankloip’s picture

damiankloip commented

@hefox, yep, this was indeed in my port patch for D7 version. I can look at the D6 patch here are add this to the D6 branch. I think I will pretty much be doing bugfixes only on the D6 branch and not really any new features (unless there are patches of course! :) ).