Closed (fixed)
Project:
LeagueSite
Version:
6.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
26 Jan 2010 at 18:11 UTC
Updated:
15 Feb 2010 at 19:00 UTC
Jump to comment: Most recent file
It was reported that the league standings do not update when the match result is entered. this patch should fix this.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | leaguesite.patch | 2.6 KB | Alun |
| #2 | leaguesite_match.patch | 3.26 KB | Alun |
| leaguesite_match.patch.txt | 3.37 KB | Alun |
Comments
Comment #1
Alun commentedThis is fixed now in the .dev version.
The alpha2 version will be brought out (which implements this fix) when I get the views integration and jQuery issues sorted.
Comment #2
Alun commentedThe patch does not work, as there are errors when deleting matches. I created a new patch for the issue.
I hope this patch works, as I have been working on the problem in between commits!
Comment #3
Alun commentedPretty sure I've fixed this now in the latest dev snapshot.
I've not got a patch as such, as I changed a LOT.
If you want to test the fix, download the latest snapshot and update. I will release alpha2 when I have finished getting the views integration sorted, which should be next week I hope.
Comment #4
Jean Rodas commentedThanks Alun the patch works great. Only one more thing in the standing, it's posible that the way of sort the positions depends on the difference of F and A because now the teams with the same points are not sorted in this way. And I wait for the integration with views in the next version. I suposs that the schedulle it comes with views.
Comment #5
Alun commentedNo problem, I will add a choice in the admin menu on how to sort teams with the same points.
Have a look at the latest development download - its fairly stable and contains some views integration for matches.
I'll keep you updated on releases.
Comment #6
Jean Rodas commentedHi Alun I try the new version "dev" and find a problem. Is not updating properly the table, when editing matches. The previous works good.
Comment #7
Alun commentedbugger. OK no problem, I'll take a look when I get the chance. Thanks for the feedback.
Comment #8
Alun commentedHere is the new, latest patch from the dev snapshot. The problem was I had a database query in the wrong place.
Jean, I've set it to needs review, so you can check it out if you get the chance. It seems to be working for me.
If it works for you, we can mark it as fixed!!
Thanks
Alun
Comment #9
Jean Rodas commentedThanks Alum for all your hard work I try the new dev and it works great. I see the integration with views too and i want to know if is possible that you can include the match date. The thing that i need with views is see the matchgames per week. I see that your module may include weeks. Then there is some way to do what i need?
Comment #10
Alun commentedYay! Glad thats sorted.
I have got to finish the views integration. I'm hoping this is done this week. Currently I store match times as a unix timestamp, but I think I will need to start using Date API, which will tie in better with Views. I think thats my next project, so you will hear more about this.
-Yes the module currently asks you about the number of a weeks a league will run, but in all honesty I am questioning the point of knowing this. Once I have addressed the Views issue, I might look at a better system for sorting out fixtures. We will see.