Closed (fixed)
Project:
Printer, email and PDF versions
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2010 at 00:40 UTC
Updated:
8 Mar 2011 at 23:30 UTC
window.print() should be in a Drupal.behaviors function instead of in onload="" so that other modules' jQuery stuff can run.
I've attached a patch with a really quick edit to the template. This should be moved into a drupal_add_js() call, but I wasn't sure what the side-effects of removing $print['sendtoprinter'] would be.
| Comment | File | Size | Author |
|---|---|---|---|
| print-jquery.patch | 1.29 KB | JamesK |
Comments
Comment #1
JamesK commentedNote: The above issue occurs in IE7/8. Unsure for other browsers.
Comment #2
jcnventuraHi,
Thanks for the patch. I've just committed it to CVS.
Comment #4
kristen polI am reopening this because the dialog does not show up for me in Firefox or Chrome on Linux with this change. It does show up if I put the window.print() back into the body onload.
Anyone able to see it for either of these 2 browsers? I tried the change from #958896: window.print() dialog not showing in Chrome (http://drupal.org/node/958896) but it did not work for me.
Thanks,
Kristen
Comment #5
jcnventuraI've tested this working, so this is not the problem. Also, please don't reopen closed issues when you've already reported the problem in another issue.