Posted by boombatower on January 27, 2010 at 4:16am
| Project: | Project Issue File Review |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
Standardize there names and meanings, and add prefixes to make them easier to document which plugins (or all) that they apply.
simpletest.tests
coder.reviews
global.directory
Comments
#1
Current arguments:
pifr_drupal:
'core' => 7,
'database' => 'mysql-5.0-isam',
'modules' => array(),
'core-url' => '',
pifr_coder:
'modules' => array(),
'directory' => '',
'pifr_coder.annotate' => FALSE,
pifr_simpletest:
'core' => 7,
'tests' => array(),
'modules' => array(),
'directory' => '',
'clone-db' => '',
other:
'test.title' => '',
Obviously latter two override pifr_drupal base...and database arugment needs to be removed.
#2
Lets shoot for something like:
'test.title' => NULL,
'test.directory.review' => '',
'test.directory.apply' => '',
'test.directory.dependency' => '',
'test.files' => array(),
'test.extensions' => array(),
'drupal.core.version' => 7,
'drupal.core.url' => ':pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal/drupal',
'drupal.modules' => array(),
'drupal.user' => 'admin',
'drupal.pass' => NULL,
'coder.annotate' => FALSE,
'simpletest.tests' => array(),
'simpletest.db' => NULL,
EDIT: Updated several times.
#3
This patch should do it, but I'm looking into more generic implementations of test.* in client.inc instead of drupal/coder/simpletest clients.
#4
Shift code around to fit new argument design, added some new useful arguments, replaced some class variables with arguments, updated debug test arrays, added update path, and fixed a few two bugs in code related to these arguments.
#5
Updated the client plugin tests, which do not run on but...thus no fail until I ran them locally.
#6
Another test fix.
#7
The last submitted patch, 696434-standard-arguments.patch, failed testing.
#8
#9
Final tweaks to test.
#10
Committed.
#11
Automatically closed -- issue fixed for 2 weeks with no activity.