Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I have marked this as a bug report because some of the things it fixes are incorrect function calls, which are bugs.
This patch is a full code cleanup of this module.
It addresses:
* Brings it up to speed with drupal coding standards - http://drupal.org/coding-standards
* Fixes incorrect call to variable_del() in hook_uninstall
* Fixes incorrect function parameters in hook_help() and hook_nodeapi()
* Changes internal function names to use the autocategorise namespace. This is to avoid function name clashes.
The patch is against 6.x-1.x-dev
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | autocategorise-696474-5.patch | 14.51 KB | agileware |
| #4 | autocategorise-696474-4.patch | 14.52 KB | agileware |
| #3 | autocategorise-696474-3.patch | 14.52 KB | agileware |
| #2 | autocategorise-696474-2.patch | 14.28 KB | agileware |
| #1 | autocategorise-696474-1.patch | 14.29 KB | agileware |
Comments
Comment #1
agileware commentedDamn patches haven't been attaching on drupal.org posts lately.
Here is the patch.
Comment #2
agileware commentedOops I just found another thing.
This version of the patch also fixes the naming of the hook_help function.
Comment #3
agileware commentedFound some more things.
This patch also changes an incorrect use of form_set_error to drupal_set_message.
It also changes the submit function to use $form_state['values'] instead of $form.
Comment #4
agileware commentedSorry, found a bug in my code.
Comment #5
agileware commentedLast one...
This one capitalises the autocategorise button as well as a couple of other code formatting fixes.
Comment #6
interx commentedWorks for me.
PS. Contributed module patches should be created from within the module itself.
Comment #7
agileware commentedCool.
Can you elaborate on the patching comment?
Do you mean something like:
from inside the amended version of the module, instead of
from outside the module directory?
If the patch applies with patch -p0 < patch.patch does it matter how it was created?
I know if you are just patching say mymodule.module you should do it in the same
directory but when you are patching multiple files can it even be done that way
and still only give one patch file?
Comment #8
brycesenz commentedThis is fixed in the latest -dev release (September 17). The module is now in line with Drupal coding standards.