Currently all cck fields support translateability.
Now what i've tried is adding a mail field with help text.

While the title of the field is perfectly translated, the help text is untouched.

For the moment i don't understand why, since it looks to me like cck added translateability in _content_field_strings_alter and also i18ncck implements it. And i have to say that general field (at least text field) translation of title/label and description/help worked already before enabling i18ncck!

For the moment i inactivated the help/description field...

So i'm going to start in email.module queue while we might need to ask cck.module or i18ncck.module queue for more information.

CommentFileSizeAuthor
#5 696542_email_description_translate_5_D6.patch538 bytesnikosnikos
#4 696542_4_email_translate.patch583 bytesmiro_dietiker
#3 fix_description_translateability.patch573 bytesberdir

Comments

nikosnikos’s picture

nikosnikos commented

I have the same problem. The description of the field isn't translated.

I think the probleme is in email.module at line 224 :

// '#description' is not translateable when I use this value
//'#description' => content_filter_xss($field['widget']['description']),
// It is translatable when I use $element['#description'] (this is how text.module do the thing)
'#description' => $element['#description'],
ferrum’s picture

ferrum commented

the same problem I currently found. I also solved it as #1 did.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 6.x-1.2 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new fix_description_translateability.patch573 bytes

Patch for the suggested change in #1.

I haven't tested this, someone should confirm that the patch works and set it to RTBC.

Note that the patch is against 6.x-1.x, but should apply with an offset against 6.x-1.2 too I assume.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new 696542_4_email_translate.patch583 bytes

No, doesn't work in 6.x-1.2.
Attached corrected patch, tested.

You needed a ['widget'] also...

nikosnikos’s picture

nikosnikos commented
StatusFileSize
new 696542_email_description_translate_5_D6.patch538 bytes

Patches #3 and #4 don't work for me. They display the description but not translated.
They both instanciate description with $field*['description'] which is not the translated description.

Solution in #1 works for me (and is from me ;) . It uses $element['#description'] which contains the translated description.
I don't know how the description is set in $element['#description'] (if someone can explain me...) but the fact is that it is translated. All process functions of cck sub-modules, like text, instanciate '#description' like that (see text_textfield_process function in text sub module)

Here is a patch with the #1 solution.

hnln’s picture

hnln commented

This bug is also present in the d7 version, should a seperate issue be created for that ?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

No, just provide a separate patch for D7 in this thread. Possibly switch version, since we first fix newer versions in Drupal.