Right now I want to upload a new gateway for ubercart project. This gateway will interact with saferpay payment system.
There aren't implementations of this already.
You can check the module at http://www.ubercart.org/contrib/15138
There aren't implementations of this already.
You can check the module at http://www.ubercart.org/contrib/15138
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | uc_saferpay.tar_.gz | 4.36 KB | sarhugo |
| #1 | uc_saferpay.tar_.gz | 4.06 KB | sarhugo |
Comments
Comment #1
sarhugo commentedComment #2
avpadernoComment #3
tr commentedI installed this module on my site and ran some test transactions. It works. I also read through the code to check that it was properly using the Ubercart APIs. I didn't see anything wrong. I researched existing payment methods and there is no duplication here - this is the only saferpay module available.
The code could use some comments and you should run it through the Coder module and clean up the small number of places where it doesn't conform to Drupal coding standards. This is the only reason I'm marking it "needs work" rather than RBTC.
Comment #4
sarhugo commentedHi, I added some function comments and also ran it throught the Coder module, fixing all the warnings.
Please check
Regards
Comment #5
tr commentedLooks good to me.
Comment #6
avpadernoJust two notes:
variable_del(); the used method could delete variables of other modules.drupal_urlencode(), rather thanurlencode().Comment #7
sarhugo commentedI'll fix these issues.
Thanks to all!
Kind Regards
Comment #8
sarhugo commentedMade the changes and uploaded the first release. Btw, excellent tutorial: http://drupal.org/handbook/cvs/quickstart
From now check for last changes at: http://drupal.org/project/uc_saferpay ;)
Regards
Comment #11
avpaderno