CVS edit link for sarhugo

Right now I want to upload a new gateway for ubercart project. This gateway will interact with saferpay payment system.
There aren't implementations of this already.
You can check the module at http://www.ubercart.org/contrib/15138
CommentFileSizeAuthor
#4 uc_saferpay.tar_.gz4.36 KBsarhugo
#1 uc_saferpay.tar_.gz4.06 KBsarhugo

Comments

sarhugo’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new4.06 KB
avpaderno’s picture

Issue tags: +Module review
tr’s picture

Status: Needs review » Needs work

I installed this module on my site and ran some test transactions. It works. I also read through the code to check that it was properly using the Ubercart APIs. I didn't see anything wrong. I researched existing payment methods and there is no duplication here - this is the only saferpay module available.

The code could use some comments and you should run it through the Coder module and clean up the small number of places where it doesn't conform to Drupal coding standards. This is the only reason I'm marking it "needs work" rather than RBTC.

sarhugo’s picture

Status: Needs work » Needs review
StatusFileSize
new4.36 KB

Hi, I added some function comments and also ran it throught the Coder module, fixing all the warnings.

Please check

Regards

tr’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Just two notes:

  • It's better to delete each Drupal variable used by the module with a call to variable_del(); the used method could delete variables of other modules.
  • It would be better to use drupal_urlencode(), rather than urlencode().
sarhugo’s picture

I'll fix these issues.

Thanks to all!
Kind Regards

sarhugo’s picture

Made the changes and uploaded the first release. Btw, excellent tutorial: http://drupal.org/handbook/cvs/quickstart
From now check for last changes at: http://drupal.org/project/uc_saferpay ;)

Regards

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes