Posted by zigazou on January 27, 2010 at 10:46pm
3 followers
Jump to:
| Project: | Media: Flickr |
| Version: | 6.x-1.10 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi !
The theme_emvideo_flickr_sets_flash function located in providers/emvideo does not generate valid XHTML 1 markup for the Flash slideshow since it uses the embed tag and param are not correctly closed.
I tried the following code under Firefox and IE6 and it seems to work well while being XHTML 1 valid.
<?php
$output = <<<EMBED
<object type="application/x-shockwave-flash" data="http://www.flickr.com/apps/slideshow/show.swf?v=71649" width="$width" height="$height">
<param name="movie" value="http://www.flickr.com/apps/slideshow/show.swf?v=71649" />
<param name="flashvars" value="offsite=true&lang=en-us&page_show_url=/$embed/show/&page_show_back_url=/$embed&set_id={$item['value']}&jump_to=" />
<param name="allowFullScreen" value="true" />
</object>
EMBED;
?>Code may need additional testing under Chrome or Safari.
Workaround for the time being is to override the function in template.php in order to include the above code.
Comments
#1
thanks; got it!
#2
Automatically closed -- issue fixed for 2 weeks with no activity.