Closed (fixed)
Project:
Media: Flickr
Version:
6.x-1.10
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
27 Jan 2010 at 22:46 UTC
Updated:
8 May 2021 at 15:46 UTC
Hi !
The theme_emvideo_flickr_sets_flash function located in providers/emvideo does not generate valid XHTML 1 markup for the Flash slideshow since it uses the embed tag and param are not correctly closed.
I tried the following code under Firefox and IE6 and it seems to work well while being XHTML 1 valid.
$output = <<<EMBED
<object type="application/x-shockwave-flash" data="http://www.flickr.com/apps/slideshow/show.swf?v=71649" width="$width" height="$height">
<param name="movie" value="http://www.flickr.com/apps/slideshow/show.swf?v=71649" />
<param name="flashvars" value="offsite=true&lang=en-us&page_show_url=/$embed/show/&page_show_back_url=/$embed&set_id={$item['value']}&jump_to=" />
<param name="allowFullScreen" value="true" />
</object>
EMBED;
Code may need additional testing under Chrome or Safari.
Workaround for the time being is to override the function in template.php in order to include the above code.
Comments
Comment #1
aaron commentedthanks; got it!