Pluggable pager legacy functions: set_item_per_page() and set_offset()

You can also reproduce the error by using

<?php
$view = views_get_view('frontpage');
$view->set_display('default');
// thats the bad line
$view->set_items_per_page(1);
print $view->preview();
?>

One example:

$view = views_get_view('frontpage');
$view->set_display('default');
// thats the bad line
$view->set_items_per_page(1);
$view->set_items_per_page(0);
print $view->preview();

Doesn't work as expected. I think we have to update $view->query->pager, too

I think we would need also it in $view->get_items_per_page $view->get_offset etc.

I think we should move up the initialization of the pager to $view::init_display. Then its definitive ready when it has to be there.

Additional this would later allow to attach settings to the query plugin, which is cool :)

I think I didn't do that because I wanted to retain the ability for the style plugin to change pagers. But maybe that's not really that big of a deal.

Latest patch (#4) does not work for me as intended. I get Fatal error: Call to a member function get_plugin() on a non-object in /home/kratib/www/d6/sites/all/modules/views/plugins/views_plugin_query.inc on line 83.

My code looks like this:

<?php
$view = views_get_view($vid);
$view->set_items_per_page(0);
?>

and that's how it used to work in Views 2.x. Seems that we now need to call $view->set_display($display_id); before calling set_items_per_page.

This may be an API change you're going to have to live with.

I think this patch ought to cover what we need. Can I get a test?

Mh

Fatal error: Call to a member function use_pager() on a non-object in /var/www/development/sites/views.dev/modules/views/includes/view.inc on line 357

I corrected this.

The tests are running fine.

Manual testing worked fine too.

The problem was:

+
+      if ($this->pager->use_pager()) {

I changed this to

+
+      if ($this->display_handler->use_pager()) {

I think that should be $this->query->use_pager()

That test is to see if the pager is actually paging. (For example, the simplest pager simply limits the number of records. It is a pager in the very strictest sense, and does not use the actual paging functionality).

Perhaps the function is misnamed?

it should be $this->query->pager->use_pager

Thanks, dereine, you saved my day. #14 works perfectly for me.

Was this a rtbc?

Update

Committed to 6.x and 7.x

The latest patch has a bug in that set_offset is called on the pager object, instead of the query object, resulting in a method not found error. The attached patch fixes this.

I just review set_offset d7 patch. The rest of the d6 patch was already rtbc.

Kudos for creating a seperate d7 patch.

Latest patch works for me.

Ok. Really, this one is committed this time.

It seems that this patch has not been applied to 3.0-alpha2