Hi,

It would be great if you could add support for Devel Generate, it's fairly simple to do (I'll possibly submit a patch if I have time) and it's an extremely useful, not only for the standard functionality of testing a content type, but also as Custom Formatters utilizes it for preview custom CCK formatters.

Cheers,
Deciphered.

CommentFileSizeAuthor
#9 link-698438-9.patch1.33 KBtim.plunkett
#2 link-6.x-2.x-dev-Support_for_Devel_Generate-698438-1.patch873 bytesdeciphered

Comments

jcfiala’s picture

jcfiala commented

Sounds like a great idea, and I look forward to your patch. :)

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs work
StatusFileSize
new link-6.x-2.x-dev-Support_for_Devel_Generate-698438-1.patch873 bytes

Patch attached.

I've marked it as 'needs work' as while it does work, it's fairly basic and I'm sure you, as the Link module developer, would be able to improve the object that is being returned and have it respect the fields defined settings.

Cheers,
Deciphered.

jcfiala’s picture

jcfiala commented
Assigned: Unassigned » jcfiala

I forgot about this until, ha! I needed it today.

Assigning it to myself so that I actually do something with this.

Thanks for the patch, Deciphered, and I apologize for letting it stay fallow for so long.

deviantintegral’s picture

deviantintegral commented

The patch in #2 is working fine for me at least for generating links and link titles.

alanburke’s picture

alanburke commented
Version: 6.x-2.x-dev » 7.x-1.x-dev

Subscribe - would be very useful [Bumping to latest version]

aaronbauman’s picture

aaronbauman
he/him
commented
Assigned: jcfiala » Unassigned

patch in #2 works fine for me on 6.x
15 months later, i'm guessing jcfiala is not still working on this...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Assigned: Unassigned » dqd

no its me now :) ...

But as project info page says already, we have a 7.x-1.0 catch up priority. Read here why: #1269718: Blockers to a 7.x-1.0 release?

I will commit all the 6.x issue immediately when 7.x-1.0 is done.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs work » Needs review

Please make sure that the latest patch works with latest 6.x --dev and I will push it overnight before ..

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new link-698438-9.patch1.33 KB

Attached is the patch for D7. Can be applied with git am.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Closed (fixed)

reviewed, tested, committed and pushed against latest dev!

thanks to
tim.plunkett++

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (fixed) » Fixed

http://drupal.org/node/156119#closed :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hefox’s picture

hefox commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Patch (to be ported)

Any reason not to backport this to 6?

jcfiala’s picture

jcfiala commented
Issue summary: View changes
Status: Patch (to be ported) » Fixed

No reason not to backport. I started with the initial 6.2 patch from earlier in this ticket, but had to make changes to make it work properly these days.

Please try the dev version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.