ucd.module checks only for node->type == 'product', but ubercart supports custom node types as well, so better to use uc_product_is_product to check if this particular type is a product

in ucd_nodeapi: if (uc_product_is_product (array('type' => $node->type)))
in ucd_ds_fields:  if(uc_product_is_product (array('type' => $type_name)))

Comments

swentel’s picture

nice one, we'll commit that this afternoon

swentel’s picture

hmm, I guess we also need to check for the fields available than too or not ? Those are probably cck fields then ?

swentel’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

d.sibaud’s picture

Version: 6.x-2.3 » 6.x-2.x-dev
Status: Active » Closed (fixed)

The same thing for ucd_content_build_modes, if the node is a custom product, it will always be excluded from the "Products in catalog grid view" by this check at line 16 of ucd_content_build_modes:

foreach ($exclude_matrix as $key => $value) {
    if ($key != 'product') {
      $exclude_matrix[$key]['catalog'] = 1;
    }
}
d.sibaud’s picture

Version: 6.x-2.x-dev » 6.x-2.3
Status: Closed (fixed) » Active

PArdon, changed to active

swentel’s picture

Version: 6.x-2.x-dev » 6.x-2.3
Status: Closed (fixed) » Fixed

I've removed that exclude matrix code, people can decide for themselves now :)

swentel’s picture

Status: Fixed » Closed (fixed)