The function _biblio_admin_get_styles() parses the module directory for 'style' files and loads them without the proper checking.
Instead of:

foreach ($files as $file) { 
  if (strstr($file, 'biblio_style_')) { 
    ... include file ... 
  }
}

it should be

foreach ($files as $file) { 
  if (strstr($file, 'biblio_style_') && preg_match('/\.inc$/',$file)) {
    ... include file ... 
  }
}

Without this, a blank page will show up because PHP exits with:

PHP Fatal error:  Cannot redeclare biblio_style_custom_info()  ...

I know there should be no temporary files in the module directory, but sometimes we need to do some checks and a temporary file is created... Well, at least, i think this should be the correct code to be there.

Comments

rjerome’s picture

Good point, I will probably just use the Drupal API file_scan_directory function to fix this.

rjerome’s picture

Status: Active » Fixed

Committed to DRUPAL-6--1 and DRUPAL-6--2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.