Two statically called functions view::load and view::load_views are missing the static keyword. If you have PHP 5.3 and strict standards enabled, this causes a warning.

I've attached a patch which fixes this. It's my first patch, so someone please tell me if I've got the format wrong in some way!

CommentFileSizeAuthor
#6 view_statics.patch530 bytesdawehner
view_statics.patch858 bytesxgretsch

Comments

merlinofchaos’s picture

merlinofchaos commented

Yeah I guess in D7 we're PHP 5 only, so we can step away from the PHP4 standards that have made this unfixable in D6.

dawehner’s picture

dawehner
Primary language German
commented

and commited.

Aren't there other places where something is statically called?

xgretsch’s picture

xgretsch commented

Probably. There are certainly some other strict warnings to do with passing things by reference that shouldn't be. As and when I come across them, I'll submit fixes if I'm able to.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs work

update version.

Figure out, whether there are other places.

xgretsch’s picture

xgretsch commented

Found another one: view::db_objects() view.inc line 1310

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new view_statics.patch530 bytes

Here is one.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

And commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.